Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 17870002: Add %_DebugBreakInOptimizedCode() pseudo function call (Closed)

Created:
7 years, 6 months ago by Jakob Kummerow
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Add %_DebugBreakInOptimizedCode() pseudo function call to insert int3/stop instructions into optimized code R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=15392

Patch Set 1 #

Total comments: 1

Patch Set 2 : renamed; added return value to avoid assertions when used in value context #

Patch Set 3 : blacklisted in fuzz-natives test; cleaned up the blacklist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M src/full-codegen.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/fuzz-natives-part1.js View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M test/mjsunit/fuzz-natives-part2.js View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M test/mjsunit/fuzz-natives-part3.js View 1 2 3 chunks +6 lines, -1 line 0 comments Download
M test/mjsunit/fuzz-natives-part4.js View 1 2 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL. Happy to rename the thing if you have a better idea. "%_BreakInOptimizedCode" maybe?
7 years, 6 months ago (2013-06-26 12:02:01 UTC) #1
Michael Starzinger
LGTM with a comment. https://codereview.chromium.org/17870002/diff/1/src/runtime.h File src/runtime.h (right): https://codereview.chromium.org/17870002/diff/1/src/runtime.h#newcode601 src/runtime.h:601: F(HDebugBreak, 0, 0) As discussed ...
7 years, 6 months ago (2013-06-26 14:16:15 UTC) #2
Michael Starzinger
Still LGTM.
7 years, 6 months ago (2013-06-26 15:32:57 UTC) #3
Jakob Kummerow
7 years, 5 months ago (2013-06-28 15:48:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698