Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java

Issue 1786813003: Fix bug in specialized handler logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
index a3898fc20ee393340958275e2a3a95d4c5fe03b5..a76da29de80f51e59b346281abe012bbf518343b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
@@ -221,7 +221,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
return isPackageSpecializedHandler(infos, null);
}
- private static boolean isPackageSpecializedHandler(List<ResolveInfo> handlers,
+ static boolean isPackageSpecializedHandler(List<ResolveInfo> handlers,
String packageName) {
if (handlers == null || handlers.size() == 0) return false;
for (ResolveInfo resolveInfo : handlers) {
@@ -231,7 +231,7 @@ public class ExternalNavigationDelegateImpl implements ExternalNavigationDelegat
// Error on the side of staying in the browser, ignore
continue;
}
- if (filter.countDataAuthorities() == 0 || filter.countDataPaths() == 0) {
+ if (filter.countDataAuthorities() == 0 && filter.countDataPaths() == 0) {
// Generic handler, skip
continue;
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698