src/gpu/gl/GrGLGpu.cpp - Issue 1786813002: Fix BGRA/RGBA readback conversions on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/gl/GrGLGpu.cpp

Issue 1786813002: Fix BGRA/RGBA readback conversions on mac (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/gl/GrGLGpu.cpp

diff --git a/src/gpu/gl/GrGLGpu.cpp b/src/gpu/gl/GrGLGpu.cpp

index f9cba433c742e29b03951d773a009d2dda0e5a06..2ddf6fc06d20278c0f405c0b6ad4efb9d106715f 100644

--- a/src/gpu/gl/GrGLGpu.cpp

+++ b/src/gpu/gl/GrGLGpu.cpp

@@ -2560,7 +2560,7 @@ bool GrGLGpu::onGetReadPixelsInfo(GrSurface* srcSurface, int width, int height,

tempDrawInfo->fSwizzle = GrSwizzle::BGRA();

tempDrawInfo->fReadConfig = kBGRA_8888_GrPixelConfig;

ElevateDrawPreference(drawPreference, kGpuPrefersDraw_DrawPreference);

- } else if (kMesa_GrGLDriver == this->glContext().driver() &&

+ } else if (this->glCaps().rgbaToBgraReadbackConversionsAreSlow() &&

GrBytesPerPixel(readConfig) == 4 &&

GrPixelConfigSwapRAndB(readConfig) == srcConfig &&

this->readPixelsSupported(srcSurface, srcConfig)) {

« no previous file with comments | « src/gpu/gl/GrGLCaps.cpp ('k') | no next file » | no next file with comments »