runtime/vm/intrinsifier_arm.cc - Issue 17868006: Fix code for store buffer update on ARM and MIPS (link register was trashed).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_arm.cc

Issue 17868006: Fix code for store buffer update on ARM and MIPS (link register was trashed). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_arm.cc

===================================================================

--- runtime/vm/intrinsifier_arm.cc (revision 24492)

+++ runtime/vm/intrinsifier_arm.cc (working copy)

@@ -237,7 +237,6 @@

// Note that R1 is Smi, i.e, times 2.

ASSERT(kSmiTagShift == 1);

- // Destroy R2 as we will not continue in the function.

__ ldr(R2, Address(SP, 0 * kWordSize)); // Value.

__ add(R1, R0, ShifterOperand(R1, LSL, 1)); // R1 is Smi.

__ StoreIntoObject(R0,

« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/intrinsifier_ia32.cc » ('j') | no next file with comments »