Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 17868006: Fix code for store buffer update on ARM and MIPS (link register was trashed). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 24492)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -1375,12 +1375,16 @@
StoreIntoObjectFilterNoSmi(object, value, &done);
}
// A store buffer update is required.
- if (value != R0) Push(R0); // Preserve R0.
+ RegList regs = (1 << LR);
+ if (value != R0) {
+ regs |= (1 << R0); // Preserve R0.
+ }
+ PushList(regs);
if (object != R0) {
mov(R0, ShifterOperand(object));
}
BranchLink(&StubCode::UpdateStoreBufferLabel());
- if (value != R0) Pop(R0); // Restore R0.
+ PopList(regs);
Bind(&done);
}
« no previous file with comments | « no previous file | runtime/vm/assembler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698