Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1786703004: Display source profiling information in Observatory (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -11 lines) Patch
M runtime/observatory/lib/src/elements/script_inset.dart View 1 2 3 4 12 chunks +178 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.html View 1 2 3 4 3 chunks +56 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
4 years, 9 months ago (2016-03-11 20:33:14 UTC) #3
turnidge
Do both of the refresh actions use the same icon?
4 years, 9 months ago (2016-03-11 22:18:21 UTC) #4
turnidge
On 2016/03/11 22:18:21, turnidge wrote: > Do both of the refresh actions use the same ...
4 years, 9 months ago (2016-03-11 22:42:19 UTC) #5
Cutch
PTAL.
4 years, 9 months ago (2016-03-14 19:27:41 UTC) #6
turnidge
lgtm w/ 1 comment https://codereview.chromium.org/1786703004/diff/60001/runtime/observatory/lib/src/elements/script_inset.html File runtime/observatory/lib/src/elements/script_inset.html (right): https://codereview.chromium.org/1786703004/diff/60001/runtime/observatory/lib/src/elements/script_inset.html#newcode28 runtime/observatory/lib/src/elements/script_inset.html:28: </polymer-element> Remove icon-timer?
4 years, 9 months ago (2016-03-14 19:34:32 UTC) #7
Cutch
4 years, 9 months ago (2016-03-14 19:39:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
08c282bf7db83b286b3d217d4ea16dd8a469ac16 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698