Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1786663003: Dirty tree scopes are always a subset of active tree scopes. (Closed)

Created:
4 years, 9 months ago by rune
Modified:
4 years, 9 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dirty tree scopes are always a subset of active tree scopes. No need to walk dirty tree scopes when clearing media dependent rule sets after walking the active tree scopes. Also clear m_dirtyTreeScopes in StyleEngine::detachFromDocument. Currently, m_dirtyTreeScopes are synchronously updated and cleared right after they are marked dirty, but that is supposed to change. BUG=567021 Committed: https://crrev.com/dba3b6817d37e512d4722aa642353b7d48db1a7d Cr-Commit-Position: refs/heads/master@{#381909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786663003/1
4 years, 9 months ago (2016-03-11 14:09:39 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/187925)
4 years, 9 months ago (2016-03-11 16:15:46 UTC) #4
rune
4 years, 9 months ago (2016-03-11 18:18:28 UTC) #6
rune
ptal
4 years, 9 months ago (2016-03-17 12:56:50 UTC) #7
esprehn
lgtm
4 years, 9 months ago (2016-03-18 05:02:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786663003/1
4 years, 9 months ago (2016-03-18 06:49:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 07:56:49 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 07:58:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dba3b6817d37e512d4722aa642353b7d48db1a7d
Cr-Commit-Position: refs/heads/master@{#381909}

Powered by Google App Engine
This is Rietveld 408576698