Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1703)

Unified Diff: Source/core/workers/WorkerThread.cpp

Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: clang compile fix Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/workers/WorkerSupplementable.h ('k') | Source/heap/Handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/workers/WorkerThread.cpp
diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp
index 7d6efc7e0b26cba91178b60b26e619b6bdb76e67..ce222b591d0fe3b659ecda6255d87f2dd003007e 100644
--- a/Source/core/workers/WorkerThread.cpp
+++ b/Source/core/workers/WorkerThread.cpp
@@ -141,6 +141,7 @@ void WorkerThread::workerThread()
// The below assignment will destroy the context, which will in turn notify messaging proxy.
// We cannot let any objects survive past thread exit, because no other thread will run GC or otherwise destroy them.
+ m_workerGlobalScope->detach();
m_workerGlobalScope = nullptr;
haraken 2014/02/26 02:39:34 Shall we change m_workerGlobalScope to RefPtrWillB
sof 2014/02/26 06:29:42 Makes sense to do that (but I didn't want to incre
// Cleanup thread heap which causes all objects to be finalized.
« no previous file with comments | « Source/core/workers/WorkerSupplementable.h ('k') | Source/heap/Handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698