Source/core/workers/WorkerThread.cpp - Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap.

Unified Diff: Source/core/workers/WorkerThread.cpp

Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use transition macro WILL_BE_USING_GARBAGE_COLLECTED_MIXIN Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/workers/WorkerThread.cpp

diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp

index 7d6efc7e0b26cba91178b60b26e619b6bdb76e67..89a0353fd78af3f8ecce7a4acb8a4304b9a459f5 100644

--- a/Source/core/workers/WorkerThread.cpp

+++ b/Source/core/workers/WorkerThread.cpp

@@ -137,10 +137,13 @@ void WorkerThread::workerThread()

ThreadIdentifier threadID = m_threadID;

+#if !ENABLE(OILPAN)

ASSERT(m_workerGlobalScope->hasOneRef());

jochen (gone - plz use gerrit) 2014/02/28 08:26:06 note that this ASSERT() does not hold. The ref cou

sof 2014/02/28 08:32:52 I see. Has it proven useful to catch out bugs in t

jochen (gone - plz use gerrit) 2014/02/28 08:35:46 It clearly indicates that there's a bug. Nobody ca

sof 2014/02/28 08:39:25 Is there a bug on it already?

+#endif

// The below assignment will destroy the context, which will in turn notify messaging proxy.

// We cannot let any objects survive past thread exit, because no other thread will run GC or otherwise destroy them.

+ m_workerGlobalScope->detach();

m_workerGlobalScope = nullptr;

// Cleanup thread heap which causes all objects to be finalized.

« no previous file with comments | « Source/core/workers/WorkerThread.h ('k') | Source/heap/Handle.h » ('j') | no next file with comments »