Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: Source/modules/crypto/WorkerGlobalScopeCrypto.h

Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make heap supplements actually be heap allocated Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/crypto/WorkerGlobalScopeCrypto.h
diff --git a/Source/modules/crypto/WorkerGlobalScopeCrypto.h b/Source/modules/crypto/WorkerGlobalScopeCrypto.h
index 9937bb6f4cea387cec74c642ef2813a3d39e5ca9..03ca68a1b94fbcb9f5932dc8e8e11ce4a819d910 100644
--- a/Source/modules/crypto/WorkerGlobalScopeCrypto.h
+++ b/Source/modules/crypto/WorkerGlobalScopeCrypto.h
@@ -31,6 +31,7 @@
#ifndef WorkerGlobalScopeCrypto_h
#define WorkerGlobalScopeCrypto_h
+#include "core/workers/WorkerGlobalScope.h"
#include "core/workers/WorkerSupplementable.h"
#include "heap/Handle.h"
@@ -39,18 +40,20 @@ namespace WebCore {
class WorkerCrypto;
class ExecutionContext;
-class WorkerGlobalScopeCrypto FINAL : public WorkerSupplement {
+class WorkerGlobalScopeCrypto FINAL : public NoBaseWillBeGarbageCollectedFinalized<WorkerGlobalScopeCrypto>, public WorkerSupplement {
Mads Ager (chromium) 2014/02/26 13:09:08 As far as I can tell we can get away with not usin
sof 2014/02/26 14:36:25 Yes, I've verified this (and for other supplements
public:
virtual ~WorkerGlobalScopeCrypto();
static WorkerGlobalScopeCrypto& from(WorkerSupplementable&);
static WorkerCrypto* crypto(WorkerSupplementable&);
WorkerCrypto* crypto() const;
+ virtual void trace(Visitor*);
+
private:
WorkerGlobalScopeCrypto();
static const char* supplementName();
- mutable RefPtrWillBePersistent<WorkerCrypto> m_crypto;
+ mutable RefPtrWillBeMember<WorkerCrypto> m_crypto;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698