Oilpan: move WorkerGlobalScope to oilpan's heap.

Source/bindings/v8/WorkerScriptController.cpp

Index: Source/bindings/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/v8/WorkerScriptController.cpp b/Source/bindings/v8/WorkerScriptController.cpp
index d1e48743e86ddaf283a94f49b51e0e8d0a2a0dc1..92164c6760a995b868c6b2e0fd792a6ef002a83a 100644
--- a/Source/bindings/v8/WorkerScriptController.cpp
+++ b/Source/bindings/v8/WorkerScriptController.cpp
@@ -161,7 +161,7 @@ bool WorkerScriptController::initializeContextIfNeeded()
         return false;
     }
 
-    V8DOMWrapper::associateObjectWithWrapper<V8WorkerGlobalScope>(PassRefPtr<WorkerGlobalScope>(m_workerGlobalScope), contextType, jsWorkerGlobalScope, isolate(), WrapperConfiguration::Dependent);
+    V8DOMWrapper::associateObjectWithWrapper<V8WorkerGlobalScope>(PassRefPtrWillBeRawPtr<WorkerGlobalScope>(&m_workerGlobalScope), contextType, jsWorkerGlobalScope, isolate(), WrapperConfiguration::Dependent);

[haraken, 2014/02/25 01:30:49]

I'm surprised that we didn't need '&' before :)

[Mads Ager (chromium), 2014/02/25 07:34:18]

PassRefPtr has a constructor that takes a const reference. We could add one for
RawPtr as well so we can avoid the '&' here. I'm not sure I prefer that though.
I think it makes it clearer what is going on to have the actual '&' here. I
wonder if a decision has been made that the style is to have a constructor from
a const reference and not use the '&' for these reference members?

[haraken, 2014/02/25 07:43:03]

I don't know, but I agree with Mads that using explicit '&' is better.

Probably we can try to remove PassRefPtr's constructor that takes a const
reference and see how many places get broken. If there're few places, we can
remove the constructor.

 
     // Insert the object instance as the prototype of the shadow object.
     v8::Handle<v8::Object> globalObject = v8::Handle<v8::Object>::Cast(m_contextHolder->context()->Global()->GetPrototype());