Oilpan: move WorkerGlobalScope to oilpan's heap.

Source/core/workers/WorkerGlobalScope.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009, 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 74 matching lines @@
     , m_timeOrigin(timeOrigin)
 {
     ScriptWrappable::init(this);
     setClient(this);
     setSecurityOrigin(SecurityOrigin::create(url));
     m_workerClients->reattachThread();
 }
 
 WorkerGlobalScope::~WorkerGlobalScope()
 {
-    ASSERT(thread()->isCurrentThread());
-
-    // Notify proxy that we are going away. This can free the WorkerThread object, so do not access it after this.
-    thread()->workerReportingProxy().workerGlobalScopeDestroyed();
-
-    setClient(0);
+    ASSERT(!m_thread);
 }
 
 void WorkerGlobalScope::applyContentSecurityPolicyFromString(const String& policy, ContentSecurityPolicy::HeaderType contentSecurityPolicyType)
 {
     setContentSecurityPolicy(ContentSecurityPolicy::create(this));
     contentSecurityPolicy()->didReceiveHeader(policy, contentSecurityPolicyType, ContentSecurityPolicy::HeaderSourceHTTP);
 }
 
 ExecutionContext* WorkerGlobalScope::executionContext() const
 {
@@ skipping 71 matching lines @@
 void WorkerGlobalScope::postTask(PassOwnPtr<ExecutionContextTask> task)
 {
     thread()->runLoop().postTask(task);
 }
 
 void WorkerGlobalScope::clearInspector()
 {
     m_workerInspectorController.clear();
 }
 
+void WorkerGlobalScope::detach()

[Mads Ager (chromium), 2014/02/26 10:22:40]

I really like this restructuring, thanks! :)

+{
+    ASSERT(thread()->isCurrentThread());
+
+    // Notify proxy that we are going away. This can free the WorkerThread object, so do not access it after this.
+    thread()->workerReportingProxy().workerGlobalScopeDestroyed();
+
+    clearScript();
+    clearInspector();
+    setClient(0);
+    clearThread();
+}
+
 void WorkerGlobalScope::importScripts(const Vector<String>& urls, ExceptionState& exceptionState)
 {
     ASSERT(contentSecurityPolicy());
     Vector<String>::const_iterator urlsEnd = urls.end();
     Vector<KURL> completedURLs;
     for (Vector<String>::const_iterator it = urls.begin(); it != urlsEnd; ++it) {
         const KURL& url = executionContext()->completeURL(*it);
         if (!url.isValid()) {
             exceptionState.throwDOMException(SyntaxError, "The URL '" + *it + "' is invalid.");
             return;
@@ skipping 71 matching lines @@
 bool WorkerGlobalScope::idleNotification()
 {
     return script()->idleNotification();
 }
 
 WorkerEventQueue* WorkerGlobalScope::eventQueue() const
 {
     return m_eventQueue.get();
 }
 
+void WorkerGlobalScope::trace(Visitor* visitor)

[Mads Ager (chromium), 2014/02/26 10:22:40]

Don't we need an explicit call to WorkerSupplementable::trace(visitor) in
anything that is WorkerSupplementable (WillBeHeapSupplementable) to get the
tracing of the supplements.

I think we carefully need to step through this code to see that we get the right
visiting behavior here.

[sof, 2014/02/26 12:25:13]

Yes, thank you. This is a major oversight when adding these GCed
supplementables; it happened to work as the supplements weren't GCed, so they
were kept alive..forever, leaking.

So, all Supplementable objects that are heap allocated must in their trace()
delegate to the Supplementable's trace().

+{
+    visitor->trace(m_console);
+    visitor->trace(m_location);
+    visitor->trace(m_navigator);
+}
+
 } // namespace WebCore