Source/core/workers/WorkerSupplementable.h - Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/workers/WorkerSupplementable.h

Issue 178663004: Oilpan: move WorkerGlobalScope to oilpan's heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove redundant include Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/workers/WorkerGlobalScope.cpp ('K') | « Source/core/workers/WorkerNavigator.idl ('k') | Source/core/workers/WorkerThread.h » ('j') | Source/heap/Handle.h » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)	5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)

6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.	6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.

7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)	7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)

8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)	8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)

9 * Copyright (C) 2013 Google Inc. All rights reserved.	9 * Copyright (C) 2013 Google Inc. All rights reserved.

10 *	10 *

(...skipping 16 matching lines...) Expand all Loading...
27	27

28 #ifndef WorkerSupplementable_h	28 #ifndef WorkerSupplementable_h

29 #define WorkerSupplementable_h	29 #define WorkerSupplementable_h

30	30

31 #include "platform/Supplementable.h"	31 #include "platform/Supplementable.h"

32	32

33 namespace WebCore {	33 namespace WebCore {

34	34

35 class WorkerGlobalScope;	35 class WorkerGlobalScope;

36	36

37 typedef Supplementable<WorkerGlobalScope> WorkerSupplementable;	37 typedef WillBeHeapSupplementable<WorkerGlobalScope> WorkerSupplementable;

38 typedef Supplement<WorkerGlobalScope> WorkerSupplement;	38 typedef WillBeHeapSupplement<WorkerGlobalScope> WorkerSupplement;
	haraken 2014/02/27 02:46:01 Let's remove this file and directly use WillBeHeap Let's remove this file and directly use WillBeHeapSupplementable<WorkerGlobalScope>. These typedefs are not that helpful and just makes underlying data structure obscure. sof 2014/02/27 08:50:37 Done (but with a faint plea not to extend CLs with Show quoted text On 2014/02/27 02:46:01, haraken wrote: > > Let's remove this file and directly use > WillBeHeapSupplementable<WorkerGlobalScope>. These typedefs are not that helpful > and just makes underlying data structure obscure. Done (but with a faint plea not to extend CLs with tidyups.)
39	39

40 } // namespace WebCore	40 } // namespace WebCore

41	41

42 #endif // WorkerSupplementable_h	42 #endif // WorkerSupplementable_h

OLD	NEW