Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1786513002: Fix paint invalidation of paintInvalidationContainer itself (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1883 matching lines...) Expand 10 before | Expand all | Expand 10 after
1894 // physical coordinate space of the paintInvalidationContainer. 1894 // physical coordinate space of the paintInvalidationContainer.
1895 const ComputedStyle& styleToUse = styleRef(); 1895 const ComputedStyle& styleToUse = styleRef();
1896 1896
1897 EPosition position = styleToUse.position(); 1897 EPosition position = styleToUse.position();
1898 1898
1899 // We need to inflate the paint invalidation rect before we use paintInvalid ationState, 1899 // We need to inflate the paint invalidation rect before we use paintInvalid ationState,
1900 // else we would forget to inflate it for the current layoutObject. FIXME: I f these were 1900 // else we would forget to inflate it for the current layoutObject. FIXME: I f these were
1901 // included into the visual overflow for repaint, we wouldn't have this issu e. 1901 // included into the visual overflow for repaint, we wouldn't have this issu e.
1902 inflatePaintInvalidationRectForReflectionAndFilter(rect); 1902 inflatePaintInvalidationRectForReflectionAndFilter(rect);
1903 1903
1904 if (paintInvalidationState && paintInvalidationState->canMapToContainer(ance stor) && position != FixedPosition) { 1904 if (paintInvalidationState && paintInvalidationState->canMapToAncestor(ances tor) && position != FixedPosition) {
1905 if (layer() && layer()->transform()) 1905 paintInvalidationState->mapObjectRectToAncestor(*this, ancestor, rect);
1906 rect = LayoutRect(layer()->transform()->mapRect(pixelSnappedIntRect( rect)));
1907
1908 // We can't trust the bits on LayoutObject, because this might be called while re-resolving style.
1909 if (styleToUse.hasInFlowPosition() && layer())
1910 rect.move(layer()->offsetForInFlowPosition());
1911
1912 rect.moveBy(location());
1913 rect.move(paintInvalidationState->paintOffset());
1914 if (paintInvalidationState->isClipped())
1915 rect.intersect(paintInvalidationState->clipRect());
1916 return; 1906 return;
1917 } 1907 }
1918 1908
1919 if (ancestor == this) { 1909 if (ancestor == this) {
1920 if (ancestor->style()->isFlippedBlocksWritingMode()) 1910 if (ancestor->style()->isFlippedBlocksWritingMode())
1921 flipForWritingMode(rect); 1911 flipForWritingMode(rect);
1922 return; 1912 return;
1923 } 1913 }
1924 1914
1925 bool containerSkipped; 1915 bool containerSkipped;
(...skipping 2752 matching lines...) Expand 10 before | Expand all | Expand 10 after
4678 } 4668 }
4679 4669
4680 void LayoutBox::IntrinsicSizingInfo::transpose() 4670 void LayoutBox::IntrinsicSizingInfo::transpose()
4681 { 4671 {
4682 size = size.transposedSize(); 4672 size = size.transposedSize();
4683 aspectRatio = aspectRatio.transposedSize(); 4673 aspectRatio = aspectRatio.transposedSize();
4684 std::swap(hasWidth, hasHeight); 4674 std::swap(hasWidth, hasHeight);
4685 } 4675 }
4686 4676
4687 } // namespace blink 4677 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698