Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 1786513002: Fix paint invalidation of paintInvalidationContainer itself (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
6 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 if (TrackedLayoutBoxListHashSet* positionedObjects = this->positionedObjects ()) { 349 if (TrackedLayoutBoxListHashSet* positionedObjects = this->positionedObjects ()) {
350 for (auto* box : *positionedObjects) { 350 for (auto* box : *positionedObjects) {
351 351
352 // One of the layoutObjects we're skipping over here may be the chil d's paint invalidation container, 352 // One of the layoutObjects we're skipping over here may be the chil d's paint invalidation container,
353 // so we can't pass our own paint invalidation container along. 353 // so we can't pass our own paint invalidation container along.
354 const LayoutBoxModelObject& paintInvalidationContainerForChild = box ->containerForPaintInvalidation(); 354 const LayoutBoxModelObject& paintInvalidationContainerForChild = box ->containerForPaintInvalidation();
355 355
356 // If it's a new paint invalidation container, we won't have properl y accumulated the offset into the 356 // If it's a new paint invalidation container, we won't have properl y accumulated the offset into the
357 // PaintInvalidationState. 357 // PaintInvalidationState.
358 // FIXME: Teach PaintInvalidationState to handle this case. crbug.co m/371485 358 // FIXME: Teach PaintInvalidationState to handle this case. crbug.co m/371485
359 if (paintInvalidationContainerForChild != childPaintInvalidationStat e.paintInvalidationContainer()) { 359 // Note: when the box itself establishes a paint invalidation contai ner, the second part of the condition below
360 // will be true because childPaintInvalidationState.paintInvalidatio nContainer() is the parent paintInvalidationContainer.
361 // We need the first part of the condition to exclude the case from using ForceHorriblySlowRectMapping.
362 if (&paintInvalidationContainerForChild != box && paintInvalidationC ontainerForChild != childPaintInvalidationState.paintInvalidationContainer()) {
360 ForceHorriblySlowRectMapping slowRectMapping(&childPaintInvalida tionState); 363 ForceHorriblySlowRectMapping slowRectMapping(&childPaintInvalida tionState);
361 PaintInvalidationState disabledPaintInvalidationState(childPaint InvalidationState, *this, paintInvalidationContainerForChild); 364 PaintInvalidationState disabledPaintInvalidationState(childPaint InvalidationState, *this, paintInvalidationContainerForChild);
362 box->invalidateTreeIfNeeded(disabledPaintInvalidationState); 365 box->invalidateTreeIfNeeded(disabledPaintInvalidationState);
363 continue; 366 continue;
364 } 367 }
365 368
366 // If the positioned layoutObject is absolutely positioned and it is inside 369 // If the positioned layoutObject is absolutely positioned and it is inside
367 // a relatively positioned inline element, we need to account for 370 // a relatively positioned inline element, we need to account for
368 // the inline elements position in PaintInvalidationState. 371 // the inline elements position in PaintInvalidationState.
369 if (box->style()->position() == AbsolutePosition) { 372 if (box->style()->position() == AbsolutePosition) {
(...skipping 2485 matching lines...) Expand 10 before | Expand all | Expand 10 after
2855 void LayoutBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Layout Object* obj) const 2858 void LayoutBlock::showLineTreeAndMark(const InlineBox* markedBox1, const char* m arkedLabel1, const InlineBox* markedBox2, const char* markedLabel2, const Layout Object* obj) const
2856 { 2859 {
2857 showLayoutObject(); 2860 showLayoutObject();
2858 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box()) 2861 for (const RootInlineBox* root = firstRootBox(); root; root = root->nextRoot Box())
2859 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1); 2862 root->showLineTreeAndMark(markedBox1, markedLabel1, markedBox2, markedLa bel2, obj, 1);
2860 } 2863 }
2861 2864
2862 #endif 2865 #endif
2863 2866
2864 } // namespace blink 2867 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698