Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 17865002: ia32: Restore missing temp register for LNumberTagU (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix non-sse2 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1988 matching lines...) Expand 10 before | Expand all | Expand 10 after
1999 DefineAsRegister(new(zone()) LDoubleToI(value, temp))); 1999 DefineAsRegister(new(zone()) LDoubleToI(value, temp)));
2000 } 2000 }
2001 } else if (from.IsInteger32()) { 2001 } else if (from.IsInteger32()) {
2002 info()->MarkAsDeferredCalling(); 2002 info()->MarkAsDeferredCalling();
2003 if (to.IsTagged()) { 2003 if (to.IsTagged()) {
2004 HValue* val = instr->value(); 2004 HValue* val = instr->value();
2005 LOperand* value = UseRegister(val); 2005 LOperand* value = UseRegister(val);
2006 if (val->HasRange() && val->range()->IsInSmiRange()) { 2006 if (val->HasRange() && val->range()->IsInSmiRange()) {
2007 return DefineSameAsFirst(new(zone()) LSmiTag(value)); 2007 return DefineSameAsFirst(new(zone()) LSmiTag(value));
2008 } else if (val->CheckFlag(HInstruction::kUint32)) { 2008 } else if (val->CheckFlag(HInstruction::kUint32)) {
2009 LNumberTagU* result = new(zone()) LNumberTagU(value); 2009 LOperand* temp = CpuFeatures::IsSupported(SSE2) ? FixedTemp(xmm1)
2010 : NULL;
2011 LNumberTagU* result = new(zone()) LNumberTagU(value, temp);
2010 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 2012 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
2011 } else { 2013 } else {
2012 LNumberTagI* result = new(zone()) LNumberTagI(value); 2014 LNumberTagI* result = new(zone()) LNumberTagI(value);
2013 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result))); 2015 return AssignEnvironment(AssignPointerMap(DefineSameAsFirst(result)));
2014 } 2016 }
2015 } else if (to.IsSmi()) { 2017 } else if (to.IsSmi()) {
2016 HValue* val = instr->value(); 2018 HValue* val = instr->value();
2017 LOperand* value = UseRegister(val); 2019 LOperand* value = UseRegister(val);
2018 LInstruction* result = 2020 LInstruction* result =
2019 DefineSameAsFirst(new(zone()) LInteger32ToSmi(value)); 2021 DefineSameAsFirst(new(zone()) LInteger32ToSmi(value));
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
2788 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2790 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2789 LOperand* object = UseRegister(instr->object()); 2791 LOperand* object = UseRegister(instr->object());
2790 LOperand* index = UseTempRegister(instr->index()); 2792 LOperand* index = UseTempRegister(instr->index());
2791 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2793 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2792 } 2794 }
2793 2795
2794 2796
2795 } } // namespace v8::internal 2797 } } // namespace v8::internal
2796 2798
2797 #endif // V8_TARGET_ARCH_IA32 2799 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698