Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 17865002: ia32: Restore missing temp register for LNumberTagU (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix non-sse2 Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4835 matching lines...) Expand 10 before | Expand all | Expand 10 after
4846 CpuFeatureScope feature_scope(masm(), SSE2); 4846 CpuFeatureScope feature_scope(masm(), SSE2);
4847 __ cvtsi2sd(xmm0, Operand(reg)); 4847 __ cvtsi2sd(xmm0, Operand(reg));
4848 } else { 4848 } else {
4849 __ push(reg); 4849 __ push(reg);
4850 __ fild_s(Operand(esp, 0)); 4850 __ fild_s(Operand(esp, 0));
4851 __ pop(reg); 4851 __ pop(reg);
4852 } 4852 }
4853 } else { 4853 } else {
4854 if (CpuFeatures::IsSupported(SSE2)) { 4854 if (CpuFeatures::IsSupported(SSE2)) {
4855 CpuFeatureScope feature_scope(masm(), SSE2); 4855 CpuFeatureScope feature_scope(masm(), SSE2);
4856 __ LoadUint32(xmm0, reg, xmm1); 4856 __ LoadUint32(xmm0, reg,
4857 ToDoubleRegister(LNumberTagU::cast(instr)->temp()));
4857 } else { 4858 } else {
4858 // There's no fild variant for unsigned values, so zero-extend to a 64-bit 4859 // There's no fild variant for unsigned values, so zero-extend to a 64-bit
4859 // int manually. 4860 // int manually.
4860 __ push(Immediate(0)); 4861 __ push(Immediate(0));
4861 __ push(reg); 4862 __ push(reg);
4862 __ fild_d(Operand(esp, 0)); 4863 __ fild_d(Operand(esp, 0));
4863 __ pop(reg); 4864 __ pop(reg);
4864 __ pop(reg); 4865 __ pop(reg);
4865 } 4866 }
4866 } 4867 }
(...skipping 1663 matching lines...) Expand 10 before | Expand all | Expand 10 after
6530 FixedArray::kHeaderSize - kPointerSize)); 6531 FixedArray::kHeaderSize - kPointerSize));
6531 __ bind(&done); 6532 __ bind(&done);
6532 } 6533 }
6533 6534
6534 6535
6535 #undef __ 6536 #undef __
6536 6537
6537 } } // namespace v8::internal 6538 } } // namespace v8::internal
6538 6539
6539 #endif // V8_TARGET_ARCH_IA32 6540 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698