Issue 1786473004: Rolls Dart runtime forward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1786473004: Rolls Dart runtime forward. (Closed)

Created:
4 years, 9 months ago by zra

Modified:
4 years, 9 months ago

Reviewers:
Cutch

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Rolls Dart runtime forward. Also copies fixes to zlib filter from upstream. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/274efa11acc5f535a51f76ffb45ca02f8f3a6355

Patch Set 1 #

Patch Set 2 : whitespace #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -131 lines)			Patch
M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/dart/embedder/common.h	View		2 chunks	+20 lines, -4 lines	0 comments	Download
M	mojo/dart/embedder/common.cc	View		1 chunk	+33 lines, -0 lines	0 comments	Download
M	mojo/dart/embedder/io/filter.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	mojo/dart/embedder/io/filter.cc	View	1	5 chunks	+35 lines, -18 lines	0 comments	Download
M	mojo/dart/embedder/io/filter_patch.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/dart/embedder/mojo_io_natives.cc	View		6 chunks	+114 lines, -102 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

4 years, 9 months ago (2016-03-11 18:32:53 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
274efa11acc5f535a51f76ffb45ca02f8f3a6355 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages