Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1786453002: Add UMA metrics for "Cast..." menu item. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA metrics for "Cast..." menu item. This change adds the following metrics: - Time between the user opening the menu and clicking the "Cast..." item. - Number of times the "Cast..." item is clicked. BUG=593797 Committed: https://crrev.com/c96faa3bf8ca74c0173b8cfc88894c69063cf100 Cr-Commit-Position: refs/heads/master@{#380676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/toolbar/app_menu_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
apacible
PTAL, thanks!
4 years, 9 months ago (2016-03-10 19:36:06 UTC) #3
Ilya Sherman
metrics lgtm
4 years, 9 months ago (2016-03-10 23:43:20 UTC) #4
Peter Kasting
LGTM
4 years, 9 months ago (2016-03-11 00:38:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786453002/1
4 years, 9 months ago (2016-03-11 17:24:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 18:27:47 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 18:29:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c96faa3bf8ca74c0173b8cfc88894c69063cf100
Cr-Commit-Position: refs/heads/master@{#380676}

Powered by Google App Engine
This is Rietveld 408576698