chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc - Issue 1786263002: Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

Issue 1786263002: Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc ('k') | chrome/common/url_constants.cc » ('j') | chrome/common/url_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

diff --git a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

index 6b07ed990906081758009bb9564f0df2ab5d2a0f..869e2b75862cf07cde6b989ee1742a78641913a1 100644

--- a/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

+++ b/chrome/common/extensions/api/storage/storage_schema_manifest_handler_unittest.cc

@@ -90,7 +90,6 @@ TEST_F(StorageSchemaManifestHandlerTest, Validate) {

permissions.AppendString("storage");

manifest_.Set("permissions", permissions.DeepCopy());

-#if defined(ENABLE_CONFIGURATION_POLICY)

// Absolute path.

manifest_.SetString("storage.managed_schema", "/etc/passwd");

EXPECT_FALSE(Validates(""));

@@ -136,7 +135,6 @@ TEST_F(StorageSchemaManifestHandlerTest, Validate) {

" \"type\": \"object\","

" \"additionalProperties\": {}"

"}"));

-#endif

// All good now.

EXPECT_TRUE(Validates(