Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome.

Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome.

This feature is always enabled for non-iOS, and iOS doesn't use src/chrome any more. The build flag to disable the feature doesn't work because it is untested and unmtained.

This is a first step to removing other uses as well.

BUG=594261
Committed: https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849
Cr-Commit-Position: refs/heads/master@{#381185}

[brettw, 2016-03-11 23:06:44]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 23:07:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786263002/20001

[brettw, 2016-03-11 23:07:39]

brettw@chromium.org changed reviewers:
+ mnissler@chromium.org

[brettw, 2016-03-11 23:07:40]

I'm trying to do this in parts, here are the src/chrome #defines only (since
this flag should always be set).

[commit-bot: I haz the power, 2016-03-11 23:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 23:21:36]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[brettw, 2016-03-11 23:25:24]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-03-11 23:25:25]

Fix

[commit-bot: I haz the power, 2016-03-11 23:25:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786263002/40001

[commit-bot: I haz the power, 2016-03-12 00:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-12 00:24:35]

Dry run: This issue passed the CQ dry run.

[Mattias Nissler (ping if slow), 2016-03-14 08:58:11]

mnissler@chromium.org changed reviewers:
+ atwilson@chromium.org, bartfab@chromium.org

[Mattias Nissler (ping if slow), 2016-03-14 08:58:11]

LGTM, but I ain't got no powers in this game anymore. Adding atwilson@ and
bartfab@

[Mattias Nissler (ping if slow), 2016-03-14 08:58:48]

Oh, I assume the build changes to remove the flag will take place in a follow-up
CL?

[brettw, 2016-03-14 17:02:51]

On 2016/03/14 08:58:48, Mattias (ping if no reply) wrote:
> Oh, I assume the build changes to remove the flag will take place in a
follow-up
> CL?

Yes, I had a patch to do that but it got out of control so I'm doing it in
parts.

[brettw, 2016-03-14 20:14:59]

Ping? Please try to let me know today if there are any concerns.

[Andrew T Wilson (Slow), 2016-03-15 00:21:40]

LGTM with one possible nit/suggestion

https://codereview.chromium.org/1786263002/diff/40001/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://codereview.chromium.org/1786263002/diff/40001/chrome/common/url_const...
chrome/common/url_constants.cc:690: kChromeUIPolicyHost,
Should this be moved up above in alphabetical order?

[brettw, 2016-03-15 05:01:59]

sort

[brettw, 2016-03-15 05:02:00]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-03-15 05:02:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
atwilson@chromium.org, mnissler@chromium.org
Link to the patchset: https://codereview.chromium.org/1786263002/#ps60001
(title: "sort")

[commit-bot: I haz the power, 2016-03-15 05:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786263002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786263002/60001

[commit-bot: I haz the power, 2016-03-15 06:27:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-15 06:28:29]

Description was changed from

==========
Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome.

This feature is always enabled for non-iOS, and iOS doesn't use src/chrome any
more. The build flag to disable the feature doesn't work because it is untested
and unmtained.

This is a first step to removing other uses as well.

BUG=594261
==========

to

==========
Remove uses of ENABLE_CONFIGURATION_POLICY from src/chrome.

This feature is always enabled for non-iOS, and iOS doesn't use src/chrome any
more. The build flag to disable the feature doesn't work because it is untested
and unmtained.

This is a first step to removing other uses as well.

BUG=594261

Committed: https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849
Cr-Commit-Position: refs/heads/master@{#381185}
==========

[commit-bot: I haz the power, 2016-03-15 06:28:31]

Patchset 4 (id:??) landed as
https://crrev.com/03e6196bfe54114abdeb714f14c4d9ba66752849
Cr-Commit-Position: refs/heads/master@{#381185}