chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarContainerTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfobarTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java

index 73b06a4212332fbd1e8956aec826ded839811996..9046e22250a85ec21a41082eed1921272f877630 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java

@@ -60,7 +60,7 @@ public class InfoBarTest extends ChromeActivityTestCaseBase<ChromeActivity> {

super.setUp();

// Register for animation notifications

- CriteriaHelper.pollForCriteria(new Criteria() {

+ CriteriaHelper.pollInstrumentationThread(new Criteria() {

@Override

public boolean isSatisfied() {

if (getActivity().getActivityTab() == null) return false;

@@ -150,7 +150,7 @@ public class InfoBarTest extends ChromeActivityTestCaseBase<ChromeActivity> {

getActivity().getActivityTab().goBack();

}

});

- CriteriaHelper.pollForCriteria(

+ CriteriaHelper.pollInstrumentationThread(

new Criteria() {

@Override

public boolean isSatisfied() {

@@ -242,7 +242,7 @@ public class InfoBarTest extends ChromeActivityTestCaseBase<ChromeActivity> {

// The renderer should have been killed and the InfoBar removed.

assertTrue("InfoBar not removed.", mListener.removeInfoBarAnimationFinished());

assertTrue("Wrong infobar count", getInfoBars().isEmpty());

- CriteriaHelper.pollForCriteria(new Criteria() {

+ CriteriaHelper.pollInstrumentationThread(new Criteria() {

@Override

public boolean isSatisfied() {

return getActivity().getActivityTab().isShowingSadTab();