chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityTaskTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

index b428b9c91bcaab1e16d9964f044b82fce3357287..5698468d4a1b3d78a440c2d592f506b4858b852e 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/UrlOverridingTest.java

@@ -195,7 +195,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity

// For sub frames, the |loadFailCallback| run through different threads

// from the ExternalNavigationHandler. As a result, there is no guarantee

// when url override result would come.

- CriteriaHelper.pollForUIThreadCriteria(

+ CriteriaHelper.pollUiThread(

new Criteria() {

@Override

public boolean isSatisfied() {

@@ -324,7 +324,7 @@ public class UrlOverridingTest extends ChromeActivityTestCaseBase<ChromeActivity

intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

targetContext.startActivity(intent);

- CriteriaHelper.pollForUIThreadCriteria(Criteria.equals(1, new Callable<Integer>() {

+ CriteriaHelper.pollUiThread(Criteria.equals(1, new Callable<Integer>() {

@Override

public Integer call() {

return mActivityMonitor.getHits();