chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/document/LauncherActivityTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

index a472ab2e87a09edbdb6246206fa0d79bfb3e5f84..fe59aa202563d0e159de0a89c766bca4e1745358 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

@@ -76,7 +76,7 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {

public void waitTillExpectedCallsComplete() {

try {

- CriteriaHelper.pollForCriteria(

+ CriteriaHelper.pollInstrumentationThread(

new Criteria("Failed while waiting for all calls to complete.") {

@Override

public boolean isSatisfied() {

@@ -147,7 +147,7 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {

public void waitForSnackbarControllerToFinish(final boolean success) {

try {

- CriteriaHelper.pollForCriteria(

+ CriteriaHelper.pollInstrumentationThread(

new Criteria("Failed while waiting for all calls to complete.") {

@Override

public boolean isSatisfied() {

@@ -448,7 +448,7 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {

dService.setOMADownloadHandler(handler);

dService.addOMADownloadToSharedPrefs(String.valueOf(downloadId) + "," + INSTALL_NOTIFY_URI);

dService.clearPendingOMADownloads();

- CriteriaHelper.pollForUIThreadCriteria(new Criteria() {

+ CriteriaHelper.pollUiThread(new Criteria() {

@Override

public boolean isSatisfied() {

return handler.mSuccess;

@@ -484,7 +484,7 @@ public class DownloadManagerServiceTest extends InstrumentationTestCase {

dService.setOMADownloadHandler(handler);

handler.setDownloadId(0);

dService.enqueueDownloadManagerRequest(info, true);

- CriteriaHelper.pollForUIThreadCriteria(new Criteria() {

+ CriteriaHelper.pollUiThread(new Criteria() {

@Override

public boolean isSatisfied() {

return handler.mDownloadId != 0;