chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java

index 6314a1f9e2b6493060d2e2c5aa800aba59f59063..b536454ebc96a01e034435ed882270a0dc7a2fc9 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java

@@ -90,7 +90,7 @@ public class AutofillPopupWithKeyboardTest extends ChromeActivityTestCaseBase<Ch

DOMUtils.clickNode(this, viewCoreRef.get(), "fn");

// Wait until the keyboard is showing.

- CriteriaHelper.pollForUIThreadCriteria(new Criteria("Keyboard was never shown.") {

+ CriteriaHelper.pollUiThread(new Criteria("Keyboard was never shown.") {

@Override

public boolean isSatisfied() {

return UiUtils.isKeyboardShowing(

@@ -100,7 +100,7 @@ public class AutofillPopupWithKeyboardTest extends ChromeActivityTestCaseBase<Ch

});

// Verify that the autofill popup is showing.

- CriteriaHelper.pollForUIThreadCriteria(

+ CriteriaHelper.pollUiThread(

new Criteria("Autofill Popup anchor view was never added.") {

@Override

public boolean isSatisfied() {

@@ -115,7 +115,7 @@ public class AutofillPopupWithKeyboardTest extends ChromeActivityTestCaseBase<Ch

});

assertTrue(popupObject instanceof AutofillPopup);

final AutofillPopup popup = (AutofillPopup) popupObject;

- CriteriaHelper.pollForUIThreadCriteria(new Criteria("Autofill Popup was never shown.") {

+ CriteriaHelper.pollUiThread(new Criteria("Autofill Popup was never shown.") {

@Override

public boolean isSatisfied() {

return popup.isShowing();