chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java - Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

Issue 1786243003: Rename pollForCriteria to pollForTestThreadCriteria. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and update MediaRouterIntegrationTest.java Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/HistoryUITest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ModalDialogTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

index a18141d806c1ddca6fd2ad32bf54da5cd76c4f0a..924be5898f9e1246e159160f019ddfc6652ed230 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

@@ -85,7 +85,7 @@ public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActi

final ListView items = (ListView) dialog.findViewById(R.id.items);

final Button button = (Button) dialog.findViewById(R.id.positive);

- CriteriaHelper.pollForUIThreadCriteria(new Criteria() {

+ CriteriaHelper.pollUiThread(new Criteria() {

@Override

public boolean isSatisfied() {

return items.getChildAt(0) != null;

@@ -95,7 +95,7 @@ public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActi

// Verify first item selected gets selected.

TouchCommon.singleClickView(items.getChildAt(position - 1));

- CriteriaHelper.pollForUIThreadCriteria(

+ CriteriaHelper.pollUiThread(

Criteria.equals(expectedEnabledState, new Callable<Boolean>() {

@Override

public Boolean call() {

@@ -107,7 +107,7 @@ public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActi

TouchCommon.singleClickView(button);

- CriteriaHelper.pollForUIThreadCriteria(

+ CriteriaHelper.pollUiThread(

Criteria.equals(expectedItemId, new Callable<String>() {

@Override

public String call() {