third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp - Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp

Issue 1786243002: [DevTools] Move restartFrame and setCallFrameVariableValue to V8DebuggerAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dgozman-patch

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/debugger/debugger-setVariableValue.html ('K') | « third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h ('k') | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp

index 4621ec2c859c46844caf8b93a8c1e0f6882b6c53..d5044590868dcfaed6786a65a692a2a8c6885695 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp

@@ -242,10 +242,9 @@ void InspectorDebuggerAgent::evaluateOnCallFrame(ErrorString* errorString,

void InspectorDebuggerAgent::setVariableValue(ErrorString* errorString, int inScopeNumber,

const String16& inVariableName,

PassOwnPtr<protocol::Runtime::CallArgument> inNewValue,

- const Maybe<String16>& inCallFrameId,

- const Maybe<String16>& inFunctionObjectId)

+ const String16& inCallFrameId)

{

- m_v8DebuggerAgent->setVariableValue(errorString, inScopeNumber, inVariableName, inNewValue, inCallFrameId, inFunctionObjectId);

+ m_v8DebuggerAgent->setVariableValue(errorString, inScopeNumber, inVariableName, inNewValue, inCallFrameId);

}

void InspectorDebuggerAgent::getBacktrace(ErrorString* errorString,