Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: runtime/vm/debugger.cc

Issue 178623003: Fix stepping after a breakpoint (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 33071)
+++ runtime/vm/debugger.cc (working copy)
@@ -1994,13 +1994,21 @@
// grows towards lower addresses.
ActivationFrame* frame = TopDartFrame();
ASSERT(frame != NULL);
- if ((stepping_fp_ != 0) && (stepping_fp_ > frame->fp())) {
- return;
+
+ if (stepping_fp_ != 0) {
+ // There is an "interesting frame" set. Only pause at appropriate
+ // locations in this frame.
+ if (stepping_fp_ > frame->fp()) {
+ // We are in a callee of the frame we're interested in.
+ // Ignore this stepping break.
+ return;
+ } else if (frame->fp() > stepping_fp_) {
+ // We returned from the "interesting frame", there can be no more
+ // stepping breaks for it. Pause at the next appropriate location
+ // and let the user set the "interesting" frame again.
+ stepping_fp_ = 0;
+ }
}
- // If an "interesting" frame is set, we are either in that frame
- // or the program has returned from that frame. Let the user set
- // the "interesting" frame again next time we pause.
- stepping_fp_ = 0;
if (!frame->IsDebuggable()) {
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698