DescriptionRevert of Switch Blink SkShader clients to sk_sp (patchset #6 id:100001 of https://codereview.chromium.org/1779833002/ )
Reason for revert:
While working on follow-up CLs it became clear that using native sk_sps in Blink fans out massively. A better approach may be to introduce helpers for adopting sk_sp into PassRefPtr and releasing PassRefPtr into sk_sp - then we only need to update the Skia/Blink API boundaries without affecting Blink's internal APIs/types.
Reverting for now to evaluate the alternative approach.
Original issue's description:
> Switch Blink SkShader clients to sk_sp
>
> Skia is migrating its APIs to the new smart pointer type - sk_sp. Among other
> benefits, the new type/APIs help avoid atomic ref count churn thanks to
> move semantics (ownership can now be transferred into Skia).
>
> 1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader>
> (instead of RefPtr<SkShader>).
> 2) use sk_sp factories (MakeFoo instead of CreateFoo)
> 3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of
> setShader(SkShader*).
>
> BUG=skia:5077
> R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromium.org
>
> Committed: https://crrev.com/12e75e492a66e801b464eefa9b61d1c5058c0c5c
> Cr-Commit-Position: refs/heads/master@{#380664}
TBR=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromium.org,mtklein@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:5077
Committed: https://crrev.com/4ca8f54e0000fc2430ec06714e0c630014eca8b3
Cr-Commit-Position: refs/heads/master@{#380698}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|