Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1786183002: Revert of Switch Blink SkShader clients to sk_sp (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, Rik, blink-reviews-platform-graphics_chromium.org, dshwang, kouhei+svg_chromium.org, fs, Justin Novosad, jbroman, danakj+watch_chromium.org, pdr+graphicswatchlist_chromium.org, f(malita), blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switch Blink SkShader clients to sk_sp (patchset #6 id:100001 of https://codereview.chromium.org/1779833002/ ) Reason for revert: While working on follow-up CLs it became clear that using native sk_sps in Blink fans out massively. A better approach may be to introduce helpers for adopting sk_sp into PassRefPtr and releasing PassRefPtr into sk_sp - then we only need to update the Skia/Blink API boundaries without affecting Blink's internal APIs/types. Reverting for now to evaluate the alternative approach. Original issue's description: > Switch Blink SkShader clients to sk_sp > > Skia is migrating its APIs to the new smart pointer type - sk_sp. Among other > benefits, the new type/APIs help avoid atomic ref count churn thanks to > move semantics (ownership can now be transferred into Skia). > > 1) convert Blink shader wrappers (Gradient, Pattern) to store sk_sp<SkShader> > (instead of RefPtr<SkShader>). > 2) use sk_sp factories (MakeFoo instead of CreateFoo) > 3) call the sk_sp paint shader setters - setShader(sk_sp<SkShader>) instead of > setShader(SkShader*). > > BUG=skia:5077 > R=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromium.org > > Committed: https://crrev.com/12e75e492a66e801b464eefa9b61d1c5058c0c5c > Cr-Commit-Position: refs/heads/master@{#380664} TBR=reed@google.com,schenney@chromium.org,junov@chromium.org,senorblanco@chromium.org,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5077 Committed: https://crrev.com/4ca8f54e0000fc2430ec06714e0c630014eca8b3 Cr-Commit-Position: refs/heads/master@{#380698}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
f(malita)
Created Revert of Switch Blink SkShader clients to sk_sp
4 years, 9 months ago (2016-03-11 19:30:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1786183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1786183002/1
4 years, 9 months ago (2016-03-11 19:32:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 19:33:05 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 19:34:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ca8f54e0000fc2430ec06714e0c630014eca8b3
Cr-Commit-Position: refs/heads/master@{#380698}

Powered by Google App Engine
This is Rietveld 408576698