Add unit test for correct serialization of autofill::PasswordForm to PasswordSpecifics.

Add unit test for correct serialization of autofill::PasswordForm to PasswordSpecifics.

BUG=593380
Committed: https://crrev.com/ac73e63122b49923dfdd76fa4de06529456a9c77
Cr-Commit-Position: refs/heads/master@{#382537}

[vasilii, 2016-03-11 17:25:35]

vasilii@chromium.org changed reviewers:
+ markusheintz@chromium.org

[vasilii, 2016-03-11 17:25:36]

Hi, please review.

[markusheintz_, 2016-03-11 18:01:16]

LGTM

https://codereview.chromium.org/1786153002/diff/20001/components/password_man...
File
components/password_manager/core/browser/password_syncable_service_unittest.cc
(right):

https://codereview.chromium.org/1786153002/diff/20001/components/password_man...
components/password_manager/core/browser/password_syncable_service_unittest.cc:612:
// Serialize empty PasswordForm and make sure the Sync representation is what
nit: "is like expected" or "is matching the expectations".

https://codereview.chromium.org/1786153002/diff/20001/components/password_man...
components/password_manager/core/browser/password_syncable_service_unittest.cc:663:
form.username_value = base::ASCIIToUTF16("username_value");
optional nit: I started using test values that are close to real values. In this
case I would use a real name because it could contain a space e.g. "Simon
Sample". 

The advantage here is that it documents the values better.

But I realize that this is an overkill here since the protocol buffer should
already be well documented. :-)

[vasilii, 2016-03-11 18:12:47]

https://codereview.chromium.org/1786153002/diff/20001/components/password_man...
File
components/password_manager/core/browser/password_syncable_service_unittest.cc
(right):

https://codereview.chromium.org/1786153002/diff/20001/components/password_man...
components/password_manager/core/browser/password_syncable_service_unittest.cc:612:
// Serialize empty PasswordForm and make sure the Sync representation is what
On 2016/03/11 18:01:16, markusheintz_ wrote:
> nit: "is like expected" or "is matching the expectations".

Done.

https://codereview.chromium.org/1786153002/diff/20001/components/password_man...
components/password_manager/core/browser/password_syncable_service_unittest.cc:663:
form.username_value = base::ASCIIToUTF16("username_value");
On 2016/03/11 18:01:16, markusheintz_ wrote:
> optional nit: I started using test values that are close to real values. In
this
> case I would use a real name because it could contain a space e.g. "Simon
> Sample". 
> 
> The advantage here is that it documents the values better.
> 
> But I realize that this is an overkill here since the protocol buffer should
> already be well documented. :-)

Done.

[vasilii, 2016-03-11 18:12:50]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-03-11 18:12:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
markusheintz@chromium.org
Link to the patchset: https://codereview.chromium.org/1786153002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2016-03-11 18:14:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786153002/40001

[commit-bot: I haz the power, 2016-03-11 19:36:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:36:12]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vasilii, 2016-03-22 08:44:11]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-03-22 08:44:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1786153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1786153002/40001

[commit-bot: I haz the power, 2016-03-22 09:13:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-22 09:13:33]

Failed to apply the patch.

[commit-bot: I haz the power, 2016-03-22 09:15:22]

Description was changed from

==========
Add unit test for correct serialization of autofill::PasswordForm to
PasswordSpecifics.

BUG=593380
==========

to

==========
Add unit test for correct serialization of autofill::PasswordForm to
PasswordSpecifics.

BUG=593380

Committed: https://crrev.com/ac73e63122b49923dfdd76fa4de06529456a9c77
Cr-Commit-Position: refs/heads/master@{#382537}
==========

[commit-bot: I haz the power, 2016-03-22 09:15:23]

Patchset 3 (id:??) landed as
https://crrev.com/ac73e63122b49923dfdd76fa4de06529456a9c77
Cr-Commit-Position: refs/heads/master@{#382537}