pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart - Issue 1786013004: Start using the new index in Analysis Server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

Issue 1786013004: Start using the new index in Analysis Server. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/test/search/element_references_test.dart » ('j') | pkg/analysis_server/test/search/element_references_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

index 06b88c0d01bd92033d368cb2445a1697be2ff547..a6fd4da0cc2333d28e0f7d9932e285df72252b10 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

@@ -96,10 +96,6 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl {

await searchEngine.searchMemberReferences(oldName);

List<SourceReference> nameRefs = getSourceReferences(nameMatches);

for (SourceReference reference in nameRefs) {

- // ignore resolved reference, we have already updated it

- if (reference.isResolved) {

- continue;

- }

// ignore references from SDK and pub cache

if (isElementInSdkOrPubCache(reference.element)) {

continue;