Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1786013004: Start using the new index in Analysis Server. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -88 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +1 line, -1 line 1 comment Download
M pkg/analysis_server/test/search/member_references_test.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 3 chunks +8 lines, -9 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 3 chunks +36 lines, -33 lines 1 comment Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 2 chunks +0 lines, -10 lines 2 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 3 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 9 months ago (2016-03-11 19:37:37 UTC) #1
Brian Wilkerson
LGTM; your call on all the comments https://codereview.chromium.org/1786013004/diff/1/pkg/analysis_server/test/search/element_references_test.dart File pkg/analysis_server/test/search/element_references_test.dart (right): https://codereview.chromium.org/1786013004/diff/1/pkg/analysis_server/test/search/element_references_test.dart#newcode742 pkg/analysis_server/test/search/element_references_test.dart:742: fail_potential_method_definedInSubclass() async ...
4 years, 9 months ago (2016-03-11 21:50:16 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 76f4578af88ef052bd8d644af3651a132b7f8ca7 (presubmit successful).
4 years, 9 months ago (2016-03-11 22:02:42 UTC) #4
scheglov
4 years, 9 months ago (2016-03-11 22:02:50 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1786013004/diff/1/pkg/analysis_server/test/se...
File pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart
(left):

https://codereview.chromium.org/1786013004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart:575:
class E {
On 2016/03/11 21:50:16, Brian Wilkerson wrote:
> Not sure why this was removed. I assume it's original purpose was to ensure
that
> we didn't rename things we shouldn't, and I don't think the semantic changes
> effect that.

Thank you for catching this.
It should have been reverted before sending this CL.
Done.

Powered by Google App Engine
This is Rietveld 408576698