tools/md_browser/md_browser.py - Issue 1786013003: [md_browser]: Sending header w/Content-Type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/md_browser/md_browser.py

Issue 1786013003: [md_browser]: Sending header w/Content-Type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/md_browser/md_browser.py

diff --git a/tools/md_browser/md_browser.py b/tools/md_browser/md_browser.py

index 5ee2fa2c16c58184f18fa1ac209ced385ebcbbf5..2b968525320c8477f944307f599cc5178d69da94 100644

--- a/tools/md_browser/md_browser.py

+++ b/tools/md_browser/md_browser.py

@@ -92,7 +92,7 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler):

if not full_path.startswith(SRC_DIR):

self._DoUnknown()

elif path == '/doc.css':

- self._WriteTemplate('doc.css')

+ self._DoCSS('doc.css')

elif not os.path.exists(full_path):

self._DoNotFound()

elif path.lower().endswith('.md'):

@@ -122,16 +122,23 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler):

extension_configs=extension_configs,

output_format='html4').encode('utf-8')

try:

+ self._WriteHeader('text/html')

self._WriteTemplate('header.html')

self.wfile.write(md_fragment)

self._WriteTemplate('footer.html')

except:

raise

+ def _DoCSS(self, template):

+ self._WriteHeader('text/css')

+ self._WriteTemplate(template)

def _DoNotFound(self):

+ self._WriteHeader('text/html')

self.wfile.write('<html><body>%s not found</body></html>' % self.path)

def _DoUnknown(self):

+ self._WriteHeader('text/html')

self.wfile.write('<html><body>I do not know how to serve %s.</body>'

'</html>' % self.path)

@@ -141,6 +148,11 @@ class Handler(SimpleHTTPServer.SimpleHTTPRequestHandler):

with codecs.open(path, encoding='utf-8') as fp:

return fp.read()

+ def _WriteHeader(self, content_type='text/plain'):

+ self.send_response(200)

+ self.send_header('Content-Type', content_type)

+ self.end_headers()

def _WriteTemplate(self, template):

contents = self._Read(os.path.join('tools', 'md_browser', template))

self.wfile.write(contents.encode('utf-8'))

« no previous file with comments | « no previous file | no next file » | no next file with comments »