Ignore viewport meta tags when Request Desktop Site is enabled.

content/public/browser/navigation_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 473 matching lines @@
   // Removes all the entries except the last committed entry. If there is a new
   // pending navigation it is preserved.  Callers must ensure
   // |CanPruneAllButLastCommitted| returns true before calling this, or it will
   // crash.
   virtual void PruneAllButLastCommitted() = 0;
 
   // Clears all screenshots associated with navigation entries in this
   // controller. Useful to reduce memory consumption in low-memory situations.
   virtual void ClearAllScreenshots() = 0;
 
+  virtual void UpdateOverridingUserAgent() = 0;

[nasko, 2016/03/18 21:05:26]

There are no callers of this method outside of content/, right? We don't add
methods to the public interface unless they are needed by other modules.

[aelias_OOO_until_Jul13, 2016/03/18 22:49:18]

On Android the content/ directory boundary doesn't map properly to the DEPS
boundary, so this seemed to be needed.  This is something Daniel and I discussed
earlier this week, we intend to start a project fix this confusion in the longer
term.

[nasko, 2016/03/25 23:29:05]

This should not go here if it is not called from outside of content/. Can you
give me a more detailed explanation of what is the problem with DEPS. Also, if
there is a DEPS issue, can't it be resolved there?

[no sievers, 2016/03/28 19:53:59]

So these call sites are impl-to-impl, right? And unnecessarily rerouted through
the public interface.

I suggest changing NavigationControllerAndroid so it has a pointer to the
NavigationControllerImpl, which you can pass in from the construction call site
in WebContentsAndroid (you can static_cast the WebContents to the
WebContentsImpl and then call WebContentsImpl::GetController()).

[aelias_OOO_until_Jul13, 2016/04/07 03:06:14]

OK, I removed the public method.  (Actually nothing was routed through the
public interface after all, just the "Impl" typing was unnecessarily dropped in
WebContentsAndroid constructor, so by adding it back there I was able to get to
the NavigationControllerImpl without resorting to a static_cast.)

+
  private:
   // This interface should only be implemented inside content.
   friend class NavigationControllerImpl;
   NavigationController() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_