Ignore viewport meta tags when Request Desktop Site is enabled.

content/browser/frame_host/navigation_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  *     (http://www.torchmobile.com/)
  *
@@ skipping 1549 matching lines @@
   entries_.erase(entries_.begin(),
                  entries_.begin() + last_committed_entry_index_);
   entries_.erase(entries_.begin() + 1, entries_.end());
   last_committed_entry_index_ = 0;
 }
 
 void NavigationControllerImpl::ClearAllScreenshots() {
   screenshot_manager_->ClearAllScreenshots();
 }
 
+void NavigationControllerImpl::UpdateOverridingUserAgent() {
+  delegate_->UpdateOverridingUserAgent();

[no sievers, 2016/03/15 20:00:05]

Does passing this to the RWH here actually work for every navigation (incl. back
for example)?

+nasko@ also since the NavigationControllerDelegate has comments that it's
temporary.
It seems like overriding WebPreferences would be better through
ContentBrowserClient::OverrideWebkitPrefs(), but it still doesn't seem
straightforward since we associate this override with the navigation entry.

[nasko, 2016/03/18 21:05:25]

Did you meant RenderViewHost? RenderWidgetHost shouldn't be dealing with user
agent information.
How would you know which RenderViewHost to send it to?
 
Yeah, that might be wrong by now :).
The current code in this CL doesn't seem to be associated at all with
NavigationEntry either. Why not take the
ContentBrowserClient::OverrideWebkitPrefs approach and just call
RenderViewHost::OnWebkitPreferencesChanged from the Android code?

[aelias_OOO_until_Jul13, 2016/03/18 22:49:18]

I took that approach initially but it failed DEPS verification when I tried to
upload the patch.  This plumbing is the simplest way I found so far that
appeared valid.

[aelias_OOO_until_Jul13, 2016/04/07 03:06:14]

I was able to remove the unnecessary new NavigationControllerImpl method by
making use of the existing NavigationControllerImpl::delegate().  (The DEPS rule
that I had been violating is that I couldn't call into WebContents from
frame_host/.)

+}
+
 void NavigationControllerImpl::SetSessionStorageNamespace(
     const std::string& partition_id,
     SessionStorageNamespace* session_storage_namespace) {
   if (!session_storage_namespace)
     return;
 
   // We can't overwrite an existing SessionStorage without violating spec.
   // Attempts to do so may give a tab access to another tab's session storage
   // so die hard on an error.
   bool successful_insert = session_storage_namespace_map_.insert(
@@ skipping 491 matching lines @@
     }
   }
 }
 
 void NavigationControllerImpl::SetGetTimestampCallbackForTest(
     const base::Callback<base::Time()>& get_timestamp_callback) {
   get_timestamp_callback_ = get_timestamp_callback;
 }
 
 }  // namespace content