Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 1785943002: Fix GCC build (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: -Wno-error=strict-overflow Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 402fe2352a382f31496a7bc707305b3fc4547b84..09a6542b9bf33dc16ff929823e84fc3111eade15 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -65,10 +65,14 @@ config("pdfium_config") {
]
}
- if (is_clang) {
+ if (is_clang || is_posix) {
# TODO(thestig): Fix all instances, remove this, pdfium:29
cflags += [ "-Wno-sign-compare" ]
}
+
+ if (is_posix && !is_clang) { # When GCC.
+ cflags += [ "-Wno-error=strict-overflow" ]
+ }
}
static_library("pdfium") {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698