Fix GCC build

BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build_overrides/v8.gni")
 import("//testing/test.gni")
 import("pdfium.gni")
 
 config("pdfium_config") {
   cflags = []
@@ skipping 47 matching lines @@
       "/wd4245",
       "/wd4310",
       "/wd4389",
       "/wd4701",
       "/wd4702",
       "/wd4706",
       "/wd4800",
     ]
   }
 
-  if (is_clang) {
+  if (is_posix) {

[Dirk Pranke, 2016/03/11 21:21:30]

This needs to be is_posix || is_clang, since there's also a win clang.

[hashimoto, 2016/03/14 06:11:31]

I know nothing about win clang, but isn't it supposed be compatible with MSVC
thus covered by the "if (is_win)" above?

[hashimoto, 2016/03/15 05:43:00]

Thanks for the clarification, done.

     # TODO(thestig): Fix all instances, remove this, pdfium:29
     cflags += [ "-Wno-sign-compare" ]
   }
 }
 
 static_library("pdfium") {
   sources = [
     "fpdfsdk/include/fsdk_actionhandler.h",
     "fpdfsdk/include/fsdk_annothandler.h",
     "fpdfsdk/include/fsdk_baseannot.h",
@@ skipping 264 matching lines @@
     "core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp",
     "core/src/fpdfapi/fpdf_parser/parser_int.h",
     "core/src/fpdfapi/fpdf_render/fpdf_render.cpp",
     "core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp",
     "core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp",
     "core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp",
     "core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp",
     "core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp",
     "core/src/fpdfapi/fpdf_render/render_int.h",
   ]
-  configs += [ ":pdfium_config" ]
+  configs -= [ "//build/config/compiler:chromium_code" ]

[Tom Sepez, 2016/03/14 16:46:54]

Can we just fix the underlying code itself?

+  configs += [
+    ":pdfium_config",
+    "//build/config/compiler:no_chromium_code",
+  ]
 }
 
 static_library("fpdftext") {
   sources = [
     "core/include/fpdftext/fpdf_text.h",
     "core/src/fpdftext/fpdf_text_int.cpp",
     "core/src/fpdftext/text_int.h",
     "core/src/fpdftext/unicodenormalization.cpp",
     "core/src/fpdftext/unicodenormalizationdata.cpp",
     "core/src/fpdftext/unicodenormalizationdata.h",
@@ skipping 1133 matching lines @@
       "//v8:v8_libplatform",
     ]
     include_dirs += [
       "//v8",
       "//v8/include",
     ]
     configs += [ "//v8:external_startup_data" ]
   }
   configs += [ ":pdfium_config" ]
 }