Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1785933003:
Reland of "[platform] Change default platform max thread pool size 4 -> 8" (Closed)
|
Created:
4 years, 9 months ago by Michael Lippautz Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionReland of "[platform] Change default platform max thread pool size 4 -> 8"
This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5.
This change was flushing out another issue which is fixed in
https://codereview.chromium.org/1783283003/
BUG=v8:2999
LOG=N
Committed: https://crrev.com/0395c50c607870561fa4f38604beff5f0b286d31
Cr-Commit-Position: refs/heads/master@{#34874}
Patch Set 1 #Patch Set 2 : #
Total comments: 4
Patch Set 3 : #Patch Set 4 : Skip flaky CollectCpuProfile #Patch Set 5 : Typo #
Messages
Total messages: 35 (18 generated)
mlippautz@chromium.org changed reviewers: + ulan@chromium.org
ptal -- relanding after the fix is in.
lgtm
The CQ bit was checked by ulan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785933003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/4228) v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785933003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785933003/40001
Patchset #2 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
alph@chromium.org changed reviewers: + alph@chromium.org
https://codereview.chromium.org/1785933003/diff/40001/test/cctest/test-cpu-pr... File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1785933003/diff/40001/test/cctest/test-cpu-pr... test/cctest/test-cpu-profiler.cc:507: " var n = 1000;\n" decrease this one to 100, so it doesn't spend too much time in each loop call. https://codereview.chromium.org/1785933003/diff/40001/test/cctest/test-cpu-pr... test/cctest/test-cpu-profiler.cc:555: int32_t profiling_interval_ms = 200; increase it to 500 as well.
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785933003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785933003/60001
Thanks for the comments, unfortunately it's still flaky. By now I am considering to disable this test, as it seems to be highly dependent on the test setup/resources and the resulting timing. https://codereview.chromium.org/1785933003/diff/40001/test/cctest/test-cpu-pr... File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/1785933003/diff/40001/test/cctest/test-cpu-pr... test/cctest/test-cpu-profiler.cc:507: " var n = 1000;\n" On 2016/03/16 21:20:00, alph wrote: > decrease this one to 100, so it doesn't spend too much time in each loop call. Done. https://codereview.chromium.org/1785933003/diff/40001/test/cctest/test-cpu-pr... test/cctest/test-cpu-profiler.cc:555: int32_t profiling_interval_ms = 200; On 2016/03/16 21:20:00, alph wrote: > increase it to 500 as well. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of "[platform] Change default platform max thread pool size 4 -> 8" This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG= ========== to ========== Reland of "[platform] Change default platform max thread pool size 4 -> 8" This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG=v8:2999 LOG=N ==========
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785933003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785933003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/4621) v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)
The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785933003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785933003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org Link to the patchset: https://codereview.chromium.org/1785933003/#ps100001 (title: "Typo")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785933003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785933003/100001
Message was sent while issue was closed.
Description was changed from ========== Reland of "[platform] Change default platform max thread pool size 4 -> 8" This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG=v8:2999 LOG=N ========== to ========== Reland of "[platform] Change default platform max thread pool size 4 -> 8" This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG=v8:2999 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Reland of "[platform] Change default platform max thread pool size 4 -> 8" This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG=v8:2999 LOG=N ========== to ========== Reland of "[platform] Change default platform max thread pool size 4 -> 8" This reverts commit 4857110ce63c91c9a9ee22fe30da9692be00a7d5. This change was flushing out another issue which is fixed in https://codereview.chromium.org/1783283003/ BUG=v8:2999 LOG=N Committed: https://crrev.com/0395c50c607870561fa4f38604beff5f0b286d31 Cr-Commit-Position: refs/heads/master@{#34874} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0395c50c607870561fa4f38604beff5f0b286d31 Cr-Commit-Position: refs/heads/master@{#34874} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
