sync/protocol/experiments_specifics.proto - Issue 1785923010: Remove kAutofillWalletSyncExperimentEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/protocol/experiments_specifics.proto

Issue 1785923010: Remove kAutofillWalletSyncExperimentEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« sync/internal_api/public/util/experiments.h ('K') | « sync/internal_api/public/util/experiments.h ('k') | sync/tools/testserver/chromiumsync.py » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Sync protocol datatype extension for experimental feature flags.	5 // Sync protocol datatype extension for experimental feature flags.

6	6

7 syntax = "proto2";	7 syntax = "proto2";

8	8

9 option optimize_for = LITE_RUNTIME;	9 option optimize_for = LITE_RUNTIME;

10 option retain_unknown_fields = true;	10 option retain_unknown_fields = true;

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 message ExperimentsSpecifics {	66 message ExperimentsSpecifics {

67 optional KeystoreEncryptionFlags keystore_encryption = 1;	67 optional KeystoreEncryptionFlags keystore_encryption = 1;

68 optional HistoryDeleteDirectives history_delete_directives = 2;	68 optional HistoryDeleteDirectives history_delete_directives = 2;

69 optional AutofillCullingFlags autofill_culling = 3;	69 optional AutofillCullingFlags autofill_culling = 3;

70 optional FaviconSyncFlags favicon_sync = 4;	70 optional FaviconSyncFlags favicon_sync = 4;

71 optional PreCommitUpdateAvoidanceFlags pre_commit_update_avoidance = 5;	71 optional PreCommitUpdateAvoidanceFlags pre_commit_update_avoidance = 5;

72 optional GcmChannelFlags gcm_channel = 6;	72 optional GcmChannelFlags gcm_channel = 6;

73 // No longer used as of M43.	73 // No longer used as of M43.

74 optional EnhancedBookmarksFlags obsolete_enhanced_bookmarks = 7;	74 optional EnhancedBookmarksFlags obsolete_enhanced_bookmarks = 7;

75 optional GcmInvalidationsFlags gcm_invalidations = 8;	75 optional GcmInvalidationsFlags gcm_invalidations = 8;

	76 // No longer used as of M51.

76 optional WalletSyncFlags wallet_sync = 9;	77 optional WalletSyncFlags wallet_sync = 9;
	Nicolas Zea 2016/03/15 18:19:27 nit: prefix with obsolete_ to ensure no one uses i nit: prefix with obsolete_ to ensure no one uses it accidentally (I think we actually read from it in sync_manager_impl.cc, which we don't need to do any more for example). Justin Donnelly 2016/03/15 20:02:26 Done. Sorry, should have done this earlier. Show quoted text On 2016/03/15 18:19:27, Nicolas Zea wrote: > nit: prefix with obsolete_ to ensure no one uses it accidentally Done. Sorry, should have done this earlier. Show quoted text > (I think we > actually read from it in sync_manager_impl.cc, which we don't need to do any > more for example). Removed the wallet section from sync_manager_impl.cc. Let me know if that looks right. There was also a reference in sync/protocol/proto_value_conversions.cc, which I removed. And just to double check, nothing I'm doing here will stop us from still syncing the wallet type, right?
77 }	78 }

OLD	NEW