Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: net/quic/quic_sent_packet_manager.h

Issue 1785863002: Remove FEC related connection options and update FEC related comment in code base. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116555910
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_sent_packet_manager.h
diff --git a/net/quic/quic_sent_packet_manager.h b/net/quic/quic_sent_packet_manager.h
index 15b12d627801f7c68414269c389726c083cc7df0..af3b953971fe631cd80dcbd192c00755a6047ad6 100644
--- a/net/quic/quic_sent_packet_manager.h
+++ b/net/quic/quic_sent_packet_manager.h
@@ -133,7 +133,7 @@ class NET_EXPORT_PRIVATE QuicSentPacketManager {
// Processes the incoming ack.
void OnIncomingAck(const QuicAckFrame& ack_frame, QuicTime ack_receive_time);
- // Returns true if the non-FEC packet |packet_number| is unacked.
+ // Returns true if packet |packet_number| is unacked.
bool IsUnacked(QuicPacketNumber packet_number) const;
// Requests retransmission of all unacked packets of |retransmission_type|.
@@ -337,7 +337,10 @@ class NET_EXPORT_PRIVATE QuicSentPacketManager {
QuicByteCount bytes_in_flight);
// Called when frames of |packet_number| has been received but the packet
- // itself has not been received by the peer (e.g., packet is revived by FEC).
+ // itself has not been received by the peer. Currently, this method is not
+ // used.
+ // TODO(fayang): Update the comment when multipath sent packet manager is
+ // landed.
// The packet needs no longer to be retransmitted, but the packet remains
// pending if it is and the congestion control does not consider the packet
// acked.
@@ -375,8 +378,8 @@ class NET_EXPORT_PRIVATE QuicSentPacketManager {
// RTT measurement purposes.
void RemoveObsoletePackets();
- // Newly serialized retransmittable and fec packets are added to this map,
- // which contains owning pointers to any contained frames. If a packet is
+ // Newly serialized retransmittable packets are added to this map, which
+ // contains owning pointers to any contained frames. If a packet is
// retransmitted, this map will contain entries for both the old and the new
// packet. The old packet's retransmittable frames entry will be nullptr,
// while the new packet's entry will contain the frames to retransmit.
« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698