Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 178583005: Move all Harmony-only tests to harmony/ (Closed)

Created:
6 years, 9 months ago by rossberg
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Move all Harmony-only tests to harmony/ R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19622

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, -781 lines) Patch
A + test/mjsunit/harmony/regress/regress-173361.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2034.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2156.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2186.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2219.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2225.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2243.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2322.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2681.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2691.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-2829.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-343928.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-crbug-248025.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-crbug-346141.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-crbug-347528.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-lookup-transition.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/regress/regress-observe-empty-double-array.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/mjsunit/harmony/set-prototype-of.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M test/mjsunit/proto-accessor.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/readonly.js View 2 chunks +7 lines, -2 lines 1 comment Download
D test/mjsunit/regress/regress-173361.js View 1 chunk +0 lines, -33 lines 0 comments Download
D test/mjsunit/regress/regress-2034.js View 1 chunk +0 lines, -46 lines 0 comments Download
D test/mjsunit/regress/regress-2156.js View 1 chunk +0 lines, -39 lines 0 comments Download
D test/mjsunit/regress/regress-2186.js View 1 chunk +0 lines, -49 lines 0 comments Download
D test/mjsunit/regress/regress-2219.js View 1 chunk +0 lines, -32 lines 0 comments Download
D test/mjsunit/regress/regress-2225.js View 1 chunk +0 lines, -65 lines 0 comments Download
D test/mjsunit/regress/regress-2243.js View 1 chunk +0 lines, -31 lines 0 comments Download
D test/mjsunit/regress/regress-2322.js View 1 chunk +0 lines, -36 lines 0 comments Download
D test/mjsunit/regress/regress-2681.js View 1 chunk +0 lines, -48 lines 0 comments Download
D test/mjsunit/regress/regress-2691.js View 1 chunk +0 lines, -34 lines 0 comments Download
D test/mjsunit/regress/regress-2829.js View 1 chunk +0 lines, -53 lines 0 comments Download
D test/mjsunit/regress/regress-343928.js View 1 chunk +0 lines, -22 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-248025.js View 1 chunk +0 lines, -40 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-346141.js View 1 chunk +0 lines, -11 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-347528.js View 1 chunk +0 lines, -36 lines 0 comments Download
D test/mjsunit/regress/regress-lookup-transition.js View 1 chunk +0 lines, -14 lines 0 comments Download
D test/mjsunit/regress/regress-observe-empty-double-array.js View 1 chunk +0 lines, -38 lines 0 comments Download
D test/mjsunit/set-prototype-of.js View 1 chunk +0 lines, -170 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 9 months ago (2014-02-28 14:22:01 UTC) #1
Jakob Kummerow
LGTM with nit (reviewed proto-accessor.js and readonly.js, rubberstamping the rest). https://codereview.chromium.org/178583005/diff/1/test/mjsunit/readonly.js File test/mjsunit/readonly.js (right): https://codereview.chromium.org/178583005/diff/1/test/mjsunit/readonly.js#newcode124 ...
6 years, 9 months ago (2014-02-28 14:25:00 UTC) #2
rossberg
6 years, 9 months ago (2014-02-28 14:26:59 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r19622.

Powered by Google App Engine
This is Rietveld 408576698