Use SkTLazy to hold path in SkClipStack::Element

Use SkTLazy to hold path in SkClipStack::Element

Committed: http://code.google.com/p/skia/source/detail?r=13610

[bsalomon, 2014-02-24 20:35:36]

Inspired by mtklein's profile from last week.

[robertphillips, 2014-02-24 20:42:24]

lgtm

[robertphillips, 2014-02-24 20:42:50]

Is it measurably faster?

[reed1, 2014-02-24 21:19:52]

dox request in SkTLazy.h

can we make SkClipStack.h private? (i.e. in src instead of include)

lgtm

https://codereview.chromium.org/178583002/diff/1/include/core/SkTLazy.h
File include/core/SkTLazy.h (right):

https://codereview.chromium.org/178583002/diff/1/include/core/SkTLazy.h#newco...
include/core/SkTLazy.h:77: void reset() {
/*
  * Destroy the lazy object (if it was created via init())
 */

[bsalomon, 2014-02-27 16:31:16]

On 2014/02/24 20:42:50, robertphillips wrote:
> Is it measurably faster?

I didn't time it. Mike Klein had a profile that I'm not exactly sure how to
repro where almost nothing was rendered due to tiny tiles and an image filter
ignoring a matrix. Creating empty paths in clipstack elements was showing up
high in the profile. I'm just asserting that this would make it better.

On 2014/02/24 21:19:52, reed1 wrote:
> dox request in SkTLazy.h
> 
> can we make SkClipStack.h private? (i.e. in src instead of include)

I'm not sure. Maybe. I'll put that in the Future Work section.

https://codereview.chromium.org/178583002/diff/1/include/core/SkTLazy.h
File include/core/SkTLazy.h (right):

https://codereview.chromium.org/178583002/diff/1/include/core/SkTLazy.h#newco...
include/core/SkTLazy.h:77: void reset() {
On 2014/02/24 21:19:52, reed1 wrote:
> /*
>   * Destroy the lazy object (if it was created via init())
>  */

Done.

[bsalomon, 2014-02-27 16:31:26]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-02-27 16:31:37]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/178583002/20001

[commit-bot: I haz the power, 2014-02-27 17:40:06]

Change committed as 13610