Enable extension support and debug layer.

Enable extension support and debug layer.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1785813002
TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/d2497f35ce9e9e70ab6c7acd82b212c80cb86d3a

[jvanverth1, 2016-03-10 21:48:54]

Description was changed from

==========
Enable extension support and debug layer.

BUG=skia:
==========

to

==========
Enable extension support and debug layer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-11 19:13:27]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[jvanverth1, 2016-03-11 19:13:41]

The CQ bit was checked by jvanverth@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 19:13:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785813002/40001

[commit-bot: I haz the power, 2016-03-11 19:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:17:21]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[jvanverth1, 2016-03-11 19:33:56]

The CQ bit was checked by jvanverth@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 19:34:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785813002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785813002/60001

[commit-bot: I haz the power, 2016-03-11 19:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 19:59:39]

Dry run: This issue passed the CQ dry run.

[egdaniel, 2016-03-16 13:40:17]

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkBuffer.cpp
File src/gpu/vk/GrVkBuffer.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkBuffer.c...
src/gpu/vk/GrVkBuffer.cpp:129: //  SkASSERT(fResource->unique());
I'm assuming this is just cause your other changed hasn't landed yet right?

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkExtensio...
File src/gpu/vk/GrVkExtensions.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkExtensio...
src/gpu/vk/GrVkExtensions.cpp:51: static void
eat_space_sep_strings(SkTArray<SkString>* out, const char in[]) {
delete this helper if not needed?

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:56: SkDebugf("%s\n", pMessage);
add layer prefix to this

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
File src/gpu/vk/GrVkInterface.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
src/gpu/vk/GrVkInterface.cpp:24: if (!extensions.init(VK_MAKE_VERSION(1, 0, 3),
hmmm not for this CL, but any thoughts on how we want to handle this versioning
in the future?

[jvanverth1, 2016-03-18 18:14:43]

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkBuffer.cpp
File src/gpu/vk/GrVkBuffer.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkBuffer.c...
src/gpu/vk/GrVkBuffer.cpp:129: //  SkASSERT(fResource->unique());
On 2016/03/16 13:40:16, egdaniel wrote:
> I'm assuming this is just cause your other changed hasn't landed yet right?

Done.

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkExtensio...
File src/gpu/vk/GrVkExtensions.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkExtensio...
src/gpu/vk/GrVkExtensions.cpp:51: static void
eat_space_sep_strings(SkTArray<SkString>* out, const char in[]) {
On 2016/03/16 13:40:16, egdaniel wrote:
> delete this helper if not needed?

Done.

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkGpu.cpp
File src/gpu/vk/GrVkGpu.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkGpu.cpp#...
src/gpu/vk/GrVkGpu.cpp:56: SkDebugf("%s\n", pMessage);
On 2016/03/16 13:40:16, egdaniel wrote:
> add layer prefix to this

Done.

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
File src/gpu/vk/GrVkInterface.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
src/gpu/vk/GrVkInterface.cpp:24: if (!extensions.init(VK_MAKE_VERSION(1, 0, 3),
On 2016/03/16 13:40:16, egdaniel wrote:
> hmmm not for this CL, but any thoughts on how we want to handle this
versioning
> in the future?

I'm not sure what you're thinking. Have a constant to set the minimum version
supported?

[egdaniel, 2016-03-18 18:22:18]

lgtm, but GrVkBuffer now had a full file worth of changes. Check line endings

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
File src/gpu/vk/GrVkInterface.cpp (right):

https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
src/gpu/vk/GrVkInterface.cpp:24: if (!extensions.init(VK_MAKE_VERSION(1, 0, 3),
On 2016/03/18 18:14:43, jvanverth1 wrote:
> On 2016/03/16 13:40:16, egdaniel wrote:
> > hmmm not for this CL, but any thoughts on how we want to handle this
> versioning
> > in the future?
> 
> I'm not sure what you're thinking. Have a constant to set the minimum version
> supported?

wasn't really thinking much besides that in the future I'm assuming we don't
want to hardcode using sdk version 1.0.3

[jvanverth1, 2016-03-18 19:15:55]

On 2016/03/18 18:22:18, egdaniel wrote:
> lgtm, but GrVkBuffer now had a full file worth of changes. Check line endings
> 
>
https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
> File src/gpu/vk/GrVkInterface.cpp (right):
> 
>
https://codereview.chromium.org/1785813002/diff/60001/src/gpu/vk/GrVkInterfac...
> src/gpu/vk/GrVkInterface.cpp:24: if (!extensions.init(VK_MAKE_VERSION(1, 0,
3),
> On 2016/03/18 18:14:43, jvanverth1 wrote:
> > On 2016/03/16 13:40:16, egdaniel wrote:
> > > hmmm not for this CL, but any thoughts on how we want to handle this
> > versioning
> > > in the future?
> > 
> > I'm not sure what you're thinking. Have a constant to set the minimum
version
> > supported?
> 
> wasn't really thinking much besides that in the future I'm assuming we don't
> want to hardcode using sdk version 1.0.3

I added a kGrVkMinimumVersion constant to GrVkUtil.h. Unfortunately querying the
driver's API 
version seems to be rather difficult -- the only place I could find was in the
PhysicalDevice
properties.

[jvanverth1, 2016-03-18 19:16:51]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-03-18 19:16:51]

The patchset sent to the CQ was uploaded after l-g-t-m from egdaniel@google.com
Link to the patchset: https://codereview.chromium.org/1785813002/#ps100001
(title: "Fixes for line endings and versioning")

[commit-bot: I haz the power, 2016-03-18 19:16:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785813002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785813002/100001

[commit-bot: I haz the power, 2016-03-18 19:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:18:50]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[jvanverth1, 2016-03-18 19:33:52]

Description was changed from

==========
Enable extension support and debug layer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Enable extension support and debug layer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com
==========

[jvanverth1, 2016-03-18 19:34:01]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-03-18 19:34:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1785813002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1785813002/100001

[commit-bot: I haz the power, 2016-03-18 19:39:07]

Description was changed from

==========
Enable extension support and debug layer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com
==========

to

==========
Enable extension support and debug layer.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d2497f35ce9e9e70ab6c7acd82b212c80cb86d3a
==========

[commit-bot: I haz the power, 2016-03-18 19:39:09]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d2497f35ce9e9e70ab6c7acd82b212c80cb86d3a