Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1785713003:
Increase GPU test timeout to avoid fragility (Closed)
|
Created:
4 years, 9 months ago by brucedawson Modified:
4 years, 9 months ago CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIncrease GPU test timeout to avoid fragility
VS 2015 64-bit debug builds were hitting tests timeouts on
WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out
that VS 2015 64-bit debug builds are, in this scenario at least, about
34% slower than VS 2013's debug builds. This means that VS 2013 is also
close to hitting this timeout, at least on slower machines.
This change increases the timeout from 180 to 300.
Bug 593983 covers investigating why VS 2015's builds are slower, but
since this issue only occurs in debug builds it is not an immediate
blocker.
TBR=kbr@chromium.org
BUG=593710, 440500, 593983
Committed: https://crrev.com/87908413585f8cc838fe2eae1581dbcc767ca49f
Cr-Commit-Position: refs/heads/master@{#380708}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 16 (8 generated)
brucedawson@chromium.org changed reviewers: + kbr@chromium.org
This fixes the timeout issue and seems appropriate. I'll investigate the (debug only) slowdown later.
nednguyen@google.com changed reviewers: + nednguyen@google.com
https://codereview.chromium.org/1785713003/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/webgl_conformance.py (right): https://codereview.chromium.org/1785713003/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/webgl_conformance.py:143: 'webglTestHarness._finished', timeout_in_seconds=300) Not my codebase but I think maybe the better way is doing polling to check if the test suite is making progress instead of doing this long wait?
On 2016/03/11 01:35:04, nednguyen wrote: > https://codereview.chromium.org/1785713003/diff/1/content/test/gpu/gpu_tests/... > File content/test/gpu/gpu_tests/webgl_conformance.py (right): > > https://codereview.chromium.org/1785713003/diff/1/content/test/gpu/gpu_tests/... > content/test/gpu/gpu_tests/webgl_conformance.py:143: > 'webglTestHarness._finished', timeout_in_seconds=300) > Not my codebase but I think maybe the better way is doing polling to check if > the test suite is making progress instead of doing this long wait? Or some combination of polling and timeouts, which allows having one timeout for time-without-progress and also a global timeout. But, I think I'll land as-is to unblock VS 2015. Improvements can be made later.
The CQ bit was checked by nednguyen@google.com
The CQ bit was unchecked by nednguyen@google.com
Description was changed from ========== Increase GPU test timeout to avoid fragility VS 2015 64-bit debug builds were hitting tests timeouts on WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out that VS 2015 64-bit debug builds are, in this scenario at least, about 34% slower than VS 2013's debug builds. This means that VS 2013 is also close to hitting this timeout, at least on slower machines. This change increases the timeout from 180 to 300. Bug 593983 covers investigating why VS 2015's builds are slower, but since this issue only occurs in debug builds it is not an immediate blocker. BUG=593710,440500,593983 ========== to ========== Increase GPU test timeout to avoid fragility VS 2015 64-bit debug builds were hitting tests timeouts on WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out that VS 2015 64-bit debug builds are, in this scenario at least, about 34% slower than VS 2013's debug builds. This means that VS 2013 is also close to hitting this timeout, at least on slower machines. This change increases the timeout from 180 to 300. Bug 593983 covers investigating why VS 2015's builds are slower, but since this issue only occurs in debug builds it is not an immediate blocker. TBR=kbr@chromium.org BUG=593710,440500,593983 ==========
Increasing timeout was suggested in https://bugs.chromium.org/p/chromium/issues/detail?id=593710#c13 so TBRing this to continue moving forwards.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785713003/1
Message was sent while issue was closed.
Description was changed from ========== Increase GPU test timeout to avoid fragility VS 2015 64-bit debug builds were hitting tests timeouts on WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out that VS 2015 64-bit debug builds are, in this scenario at least, about 34% slower than VS 2013's debug builds. This means that VS 2013 is also close to hitting this timeout, at least on slower machines. This change increases the timeout from 180 to 300. Bug 593983 covers investigating why VS 2015's builds are slower, but since this issue only occurs in debug builds it is not an immediate blocker. TBR=kbr@chromium.org BUG=593710,440500,593983 ========== to ========== Increase GPU test timeout to avoid fragility VS 2015 64-bit debug builds were hitting tests timeouts on WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out that VS 2015 64-bit debug builds are, in this scenario at least, about 34% slower than VS 2013's debug builds. This means that VS 2013 is also close to hitting this timeout, at least on slower machines. This change increases the timeout from 180 to 300. Bug 593983 covers investigating why VS 2015's builds are slower, but since this issue only occurs in debug builds it is not an immediate blocker. TBR=kbr@chromium.org BUG=593710,440500,593983 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Increase GPU test timeout to avoid fragility VS 2015 64-bit debug builds were hitting tests timeouts on WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out that VS 2015 64-bit debug builds are, in this scenario at least, about 34% slower than VS 2013's debug builds. This means that VS 2013 is also close to hitting this timeout, at least on slower machines. This change increases the timeout from 180 to 300. Bug 593983 covers investigating why VS 2015's builds are slower, but since this issue only occurs in debug builds it is not an immediate blocker. TBR=kbr@chromium.org BUG=593710,440500,593983 ========== to ========== Increase GPU test timeout to avoid fragility VS 2015 64-bit debug builds were hitting tests timeouts on WebglConformance.conformance_uniforms_gl_uniform_arrays. It turns out that VS 2015 64-bit debug builds are, in this scenario at least, about 34% slower than VS 2013's debug builds. This means that VS 2013 is also close to hitting this timeout, at least on slower machines. This change increases the timeout from 180 to 300. Bug 593983 covers investigating why VS 2015's builds are slower, but since this issue only occurs in debug builds it is not an immediate blocker. TBR=kbr@chromium.org BUG=593710,440500,593983 Committed: https://crrev.com/87908413585f8cc838fe2eae1581dbcc767ca49f Cr-Commit-Position: refs/heads/master@{#380708} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/87908413585f8cc838fe2eae1581dbcc767ca49f Cr-Commit-Position: refs/heads/master@{#380708}
Message was sent while issue was closed.
lgtm after the fact https://codereview.chromium.org/1785713003/diff/1/content/test/gpu/gpu_tests/... File content/test/gpu/gpu_tests/webgl_conformance.py (right): https://codereview.chromium.org/1785713003/diff/1/content/test/gpu/gpu_tests/... content/test/gpu/gpu_tests/webgl_conformance.py:143: 'webglTestHarness._finished', timeout_in_seconds=300) On 2016/03/11 01:35:03, nednguyen wrote: > Not my codebase but I think maybe the better way is doing polling to check if > the test suite is making progress instead of doing this long wait? I'm not sure how that would be implemented -- there aren't any convenient hooks in the WebGL tests to detect progress. This seems OK. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
