Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1785713002: Fixed WebKit layout test harness to work with Windows 10 SDK (Closed)

Created:
4 years, 9 months ago by kylix_rd
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, scottmg
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed WebKit layout test harness to work with Windows 10 SDK BUG= Committed: https://crrev.com/822f853cb44ae64c8dabe6b2092f0ae061308c0d Cr-Commit-Position: refs/heads/master@{#380473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_win.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
kylix_rd
4 years, 9 months ago (2016-03-10 19:16:07 UTC) #3
scottmg
lgtm but you'll need an owner, maybe +dpranke
4 years, 9 months ago (2016-03-10 19:19:08 UTC) #5
kylix_rd
On 2016/03/10 19:19:08, scottmg wrote: > lgtm but you'll need an owner, maybe +dpranke Nearest ...
4 years, 9 months ago (2016-03-10 19:26:39 UTC) #6
Dirk Pranke
lgtm ... I'm as good a person as any to review this ...
4 years, 9 months ago (2016-03-10 19:27:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785713002/1
4 years, 9 months ago (2016-03-10 19:30:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 21:38:16 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 21:39:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/822f853cb44ae64c8dabe6b2092f0ae061308c0d
Cr-Commit-Position: refs/heads/master@{#380473}

Powered by Google App Engine
This is Rietveld 408576698