Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1785693002: Happify dumb coverage checker (Closed)

Created:
4 years, 9 months ago by rossberg
Modified:
4 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Happify dumb coverage checker This is old code, and the same pattern appears in other places. I have no idea what the checker's problem is all of a sudden... TBR=machenbach@chromium.org BUG= Committed: https://crrev.com/62bf607f7971478c599ab537e74b17c7caa36477 Cr-Commit-Position: refs/heads/master@{#34676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/parsing/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rossberg
4 years, 9 months ago (2016-03-10 13:44:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785693002/1
4 years, 9 months ago (2016-03-10 13:45:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 14:07:17 UTC) #4
Michael Achenbach
lgtm, thanks!
4 years, 9 months ago (2016-03-10 14:08:44 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 14:08:59 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/62bf607f7971478c599ab537e74b17c7caa36477
Cr-Commit-Position: refs/heads/master@{#34676}

Powered by Google App Engine
This is Rietveld 408576698