third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html - Issue 1785663002: Make setBaseAndExtent's arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use collapse() where possible (one test) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html ('k') | third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html b/third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html

index 7a6fced71d4c1f9e8e9fd419f1cab85e65f17ed3..22762386abff5cb102c50011e50d00d9a0acf713 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html

@@ -6,9 +6,14 @@

<body>

var selection = getSelection();

+var node = document.body;

shouldThrow("selection.addRange()");

shouldThrow("selection.getRangeAt()");

shouldThrow("selection.selectAllChildren()");

+shouldThrow("selection.setBaseAndExtent()");

+shouldThrow("selection.setBaseAndExtent(node)");

+shouldThrow("selection.setBaseAndExtent(node, 0)");

+shouldThrow("selection.setBaseAndExtent(node, 0, node)");

</script>

</body>

</html>