third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html - Issue 1785663002: Make setBaseAndExtent's arguments non-optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html

Issue 1785663002: Make setBaseAndExtent's arguments non-optional (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/execCommand/apply-inline-style-to-element-with-no-renderer-crash.html ('K') | « third_party/WebKit/LayoutTests/fast/block/float/float-list-changed-before-layout-crash.html ('k') | third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html b/third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html

index 18e3374f396e969e1d29e421a017fdc5f7e479db..746ef7e5ad93a0ecd9b2622d6c94c62bef2ea6fb 100644

--- a/third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html

+++ b/third_party/WebKit/LayoutTests/fast/css-generated-content/crash-selection-editing-removes-pseudo.html

@@ -31,7 +31,7 @@ var start = document.getElementById('start');

var test = document.getElementById('test');

// Select from the #start backwards to the start of the line.

-window.getSelection().setBaseAndExtent(document.getElementById('start'));

+window.getSelection().setBaseAndExtent(document.getElementById('start'), 0, null, 0);

window.getSelection().modify('extend', 'backward', 'lineBoundary')

// Replace the selection with a break. This replaces #before, text,