Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1785653002: WTF TypeTraits: Fix IsTrivially{DefaultConstructible,Destructible}. (Closed)

Created:
4 years, 9 months ago by Yuta Kitamura
Modified:
4 years, 9 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF TypeTraits: Fix IsTrivially{DefaultConstructible,Destructible}. This is a follow-up of an earlier CL: https://codereview.chromium.org/1771303002/ This patch fixes two type traits so they can properly consider deleted constructors and destructors. The strategy is pretty similar to the one of the previous CL. BUG=592767 Committed: https://crrev.com/1d3fb1ed5618c3ac47842ed8f9100a7b4cfdbc2a Cr-Commit-Position: refs/heads/master@{#380519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M third_party/WebKit/Source/wtf/TypeTraits.h View 1 chunk +29 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/TypeTraitsTest.cpp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785653002/1
4 years, 9 months ago (2016-03-10 11:15:47 UTC) #2
Yuta Kitamura
PTAL?
4 years, 9 months ago (2016-03-10 11:16:03 UTC) #6
tzik
lgtm
4 years, 9 months ago (2016-03-10 11:20:34 UTC) #7
haraken
owner LGTM (relying on tzik's offline review and LG here)
4 years, 9 months ago (2016-03-10 11:21:49 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 12:45:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785653002/1
4 years, 9 months ago (2016-03-11 04:30:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 05:18:00 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 05:19:48 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d3fb1ed5618c3ac47842ed8f9100a7b4cfdbc2a
Cr-Commit-Position: refs/heads/master@{#380519}

Powered by Google App Engine
This is Rietveld 408576698