Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 1785643002: Update avatar icon when nonclient frame view is added to view hierarchy. (Closed)

Created:
4 years, 9 months ago by Peter Kasting
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update avatar icon when nonclient frame view is added to view hierarchy. This replaces the unconditional update done in (or right after) construction in the subclasses. I need to add a ViewHierarchyChanged() override anyway, so I can set up a widget observer later, but I'm separating this bit out first to try to tease out what's causing trybot failures. BUG=none TEST=none Committed: https://crrev.com/fbf8325c80b23b5d1fba75e6fd77083cea8ed005 Cr-Commit-Position: refs/heads/master@{#381773}

Patch Set 1 #

Patch Set 2 : Remove hopefully-unnecessary check #

Patch Set 3 : More consistent calling of GetNativeWindow() #

Messages

Total messages: 10 (5 generated)
Peter Kasting
4 years, 9 months ago (2016-03-17 04:25:50 UTC) #4
sky
LGTM
4 years, 9 months ago (2016-03-17 19:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1785643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1785643002/40001
4 years, 9 months ago (2016-03-17 19:24:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 19:30:51 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 19:32:01 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fbf8325c80b23b5d1fba75e6fd77083cea8ed005
Cr-Commit-Position: refs/heads/master@{#381773}

Powered by Google App Engine
This is Rietveld 408576698